Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to merge video & subtitles into one mkv? #84

Closed
smithmarci opened this issue Apr 17, 2021 · 4 comments
Closed

Option to merge video & subtitles into one mkv? #84

smithmarci opened this issue Apr 17, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@smithmarci
Copy link

Hi Maxstupo!

Would it make sense and/or would be possible to add an option for merging the downloaded video and the subtitle file(s) into one '.mkv' (or into any other container with the same capabilities (by drop-down selection, maybe))? And, without re-encoding the video, of course.

I am uninitiated in things like this. Although, the following problem/solution seems to fit the suggestion in question:
https://superuser.com/questions/958680/ffmpeg-mp4-and-multiple-srt-into-mkv

As I understand, the subtitles would need to be converted to '.srt' format first, but - according to several forum sources - 'youtube-dl' does not seem to handle the conversion properly. However, and if I am not mistaken, for that purpose 'ffmpeg' again should do the trick. I could imagine this mode of operation to leave the standalone '.vtt' files as well, for safekeeping.

Do you think that such function could be useful? Or it is beyond the aim of the software?

@Maxstupo
Copy link
Owner

Ideally I would like YDL-UI to only interact with youtube-dl. However, youtube-dl does have the --embed-subs flag.

Embed subtitles in the video (only for mp4, webm and mkv videos)

From a quick test it seems like vtt subs will get embedded into mkv.

@smithmarci
Copy link
Author

That's great news! If this result can be achieved with one component - plus, that component is 'youtube-dl' -, then all the better. Thank you for taking the time and looking into that!

@smithmarci
Copy link
Author

smithmarci commented Apr 26, 2021

However, youtube-dl does have the --embed-subs flag.

Are you planning tho add this flag via check-box option (in the 'General' / 'File system' section, perhaps)? Or the new 'Custom arguments' option on the 'Preview' tab is there exactly for this kind of individually preferred parameters?

Will this new option & tooltip localizable (?) later?

@Maxstupo
Copy link
Owner

@smithmarci I was planning to use a check-box option. The Custom Arguments option is for flags that haven't been implemented as a control yet, or for edge cases when you need flags like --no-check-certificate

When added the option & tooltip should be localizable.

@Maxstupo Maxstupo added the enhancement New feature or request label Apr 26, 2021
@Maxstupo Maxstupo closed this as completed May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants