Update test for upcoming tmap v4 #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Changes to the current development version of tmap (version 4) require significant updates to the plotting code in stateMap.R and countyMap.R.
Unfortunately, this is not a priority item for my time at the moment and will have to wait ... probably until tmap version 4 is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tmap will soon release its version 4.0, which is a complete overhaul of the package.
Some of tmap internal objects will change due to this, which makes MazamaSpatialPlots fail.
This PR makes sure that MazamaSpatialPlots tests pass with CRAN tmap (3.3.4) and upcoming tmap v4
If possible, a CRAN release would be great!
cc @mtennekes r-tmap/tmap#908
Feel free to do more testing of your package with dev tmap (installable with
pak::pak("r-tmap/tmap")and report back if something is not working as expected.