Skip to content

Commit

Permalink
Harmonize static function compiler flags
Browse files Browse the repository at this point in the history
Warnings are treated as errors in Mbed TLS test. An error
"ssl_parse_client_hello_v2’ defined but not used" can occur in some
specific configurations and therefore tests will break.

Use similar flags for static function "ssl_parse_client_hello_v2" as
what is used when calling the function to prevent the compilation
warning/error.
  • Loading branch information
Arto Kinnunen committed Sep 30, 2019
1 parent bf77960 commit d198672
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions library/ssl_srv.c
Original file line number Diff line number Diff line change
Expand Up @@ -1059,7 +1059,8 @@ static int ssl_ciphersuite_is_match( mbedtls_ssl_context *ssl,
return( 1 );
}

#if defined(MBEDTLS_SSL_SRV_SUPPORT_SSLV2_CLIENT_HELLO)
#if defined(MBEDTLS_SSL_SRV_SUPPORT_SSLV2_CLIENT_HELLO) && \
defined(MBEDTLS_SSL_PROTO_TLS)
static int ssl_parse_client_hello_v2( mbedtls_ssl_context *ssl )
{
int ret, got_common_suite;
Expand Down Expand Up @@ -1363,7 +1364,7 @@ static int ssl_parse_client_hello_v2( mbedtls_ssl_context *ssl )

return( 0 );
}
#endif /* MBEDTLS_SSL_SRV_SUPPORT_SSLV2_CLIENT_HELLO */
#endif /* MBEDTLS_SSL_SRV_SUPPORT_SSLV2_CLIENT_HELLO && MBEDTLS_SSL_PROTO_TLS */

/* This function doesn't alert on errors that happen early during
ClientHello parsing because they might indicate that the client is
Expand Down

0 comments on commit d198672

Please sign in to comment.