Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All VS2010 projects have incorrect Release|x64 configuration #1430

Closed
irwir opened this issue Mar 9, 2018 · 9 comments · Fixed by #2853
Closed

All VS2010 projects have incorrect Release|x64 configuration #1430

irwir opened this issue Mar 9, 2018 · 9 comments · Fixed by #2853
Labels
bug component-platform Portability layer and build scripts help-wanted This issue is not being actively worked on, but PRs welcome.

Comments

@irwir
Copy link
Contributor

irwir commented Mar 9, 2018 •
edited
Loading

Description

  • Type: Bug
  • Priority: Minor

Bug

All VS2010 projects have an error in Release|x64 configuration.
This line must be deleted:
<PlatformToolset>Windows7.1SDK</PlatformToolset>
In that case the value would be inherited from project defaults, which is fine - as it is in other configurations.
If PlatformToolset was to be defined, the value should have been v100.
It looks like a TargetPlatform definition, but in that case the line is in the wrong place; and this is not necessary either.

OS
Mbed OS: Windows

mbed TLS build:
The bug was present in development branch since the first commit.
@simonbutcher
Copy link
Contributor

Thanks for the feedback! We'll look into this.

@ciarmcom
Copy link

ARM Internal Ref: IOTSSL-2165

@irwir
Copy link
Contributor Author

irwir commented Mar 15, 2018

A sed command deleting the lines with the pattern and applied to all *.vcxproj files should do the trick:
/Windows7.1SDK/d

@simonbutcher simonbutcher mentioned this issue Mar 27, 2018
Open
2 tasks
@irwir
Copy link
Contributor Author

irwir commented Jun 12, 2018

This trivial change is of the kind that are cheaper to fix and forget immediately rather than keep and maintain in the list.
Is there anything blocking, or maybe a PR is needed?

@RonEld RonEld added the component-platform Portability layer and build scripts label Feb 17, 2019
@RonEld RonEld added tracking archived Do not use - historically applied to archived issues help-wanted This issue is not being actively worked on, but PRs welcome. and removed tracking help-wanted This issue is not being actively worked on, but PRs welcome. labels Jun 13, 2019
@RonEld RonEld closed this as completed Jun 13, 2019
@hanno-becker
Copy link

@RonEld Why is this being closed?

Patater added a commit to Patater/mbedtls that referenced this issue Jun 19, 2019
@Patater
windows: Fix Release x64 configuration
91ebdb1 
Inherit PlatformToolset from the project configuration. This allow the
project to configure PlatformToolset, and aligns the Release x64 build
with other build types.

Fixes Mbed-TLS#1430
Patater added a commit to Patater/mbedtls that referenced this issue Jun 19, 2019
@Patater
windows: Fix Release x64 configuration
445d129 
Inherit PlatformToolset from the project configuration. This allow the
project to configure PlatformToolset, and aligns the Release x64 build
with other build types.

Fixes Mbed-TLS#1430
Patater added a commit to Patater/mbedtls that referenced this issue Jun 20, 2019
@Patater
windows: Fix Release x64 configuration
4f4af6e 
Inherit PlatformToolset from the project configuration. This allow the
project to configure PlatformToolset, and aligns the Release x64 build
with other build types.

Fixes Mbed-TLS#1430
Patater added a commit to Patater/mbedtls that referenced this issue Jun 20, 2019
@Patater
windows: Fix Release x64 configuration
a33bb94 
Inherit PlatformToolset from the project configuration. This allow the
project to configure PlatformToolset, and aligns the Release x64 build
with other build types.

Fixes Mbed-TLS#1430
Patater added a commit to Patater/mbedtls that referenced this issue Jun 20, 2019
@Patater
windows: Fix Release x64 configuration
73a36ff 
Inherit PlatformToolset from the project configuration. This allow the
project to configure PlatformToolset, and aligns the Release x64 build
with other build types.

Fixes Mbed-TLS#1430
@irwir irwir mentioned this issue Jul 11, 2019
Closed
@irwir
Copy link
Contributor Author

irwir commented Sep 4, 2019 •
edited
Loading

The issue was mostly fixed in the development branches of both mbedtls and mbedtls-crypto.
But there is one complication.
The main projects visualc\VS2010\mbedTLS.vcxproj, unlike others, are created from
the corresponding templates scripts\data_files\vs2010-main-template.vcxproj.
Since that was overlooked in the initial issue report, the offending string <PlatformToolset>Windows7.1SDK</PlatformToolset> still exists in templates and mbedTLS.vcxproj files.

@Patater Patater reopened this Sep 4, 2019
@Patater Patater removed archived Do not use - historically applied to archived issues closed_in_jira labels Sep 4, 2019
@Patater Patater removed the mirrored label Sep 4, 2019
@Patater
Copy link
Contributor

Patater commented Sep 4, 2019

@irwir Please raise PRs and we can review and merge from there. Thanks!

@irwir
Copy link
Contributor Author

irwir commented Sep 4, 2019

@Patater
Would it be possible to merge more than one tiny issues into one PR?

@Patater
Copy link
Contributor

Patater commented Sep 4, 2019

@irwir The smaller the PR, the quicker it is for us to review and merge. Large PRs tend to get left behind and go stale. The preferred approach is multiple PRs that can be merged independently.

irwir added a commit to irwir/mbedtls that referenced this issue Sep 21, 2019
@irwir
Finalize fixing the issue Mbed-TLS#1430.
ea9c53d 
The previous PRs had correct template project, but somehow it was not merged.
@irwir irwir mentioned this issue Sep 21, 2019
Merged
irwir added a commit to irwir/mbedtls that referenced this issue Apr 19, 2020
@irwir
Finalize fixing the issue Mbed-TLS#1430.
49d46a7 
The previous PRs had correct template project, but somehow it was not merged.

Signed-off-by: irwir <irwir@users.noreply.github.com>
@mpg mpg closed this as completed in #2853 Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug component-platform Portability layer and build scripts help-wanted This issue is not being actively worked on, but PRs welcome.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Finalize fixing bugs in .vcxproj files irwir/mbedtls
6 participants
@Patater @simonbutcher @ciarmcom @irwir @RonEld @hanno-becker