Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ header test doesn't clean up #1862

Closed
simonbutcher opened this issue Jul 16, 2018 · 1 comment
Closed

C++ header test doesn't clean up #1862

simonbutcher opened this issue Jul 16, 2018 · 1 comment
Labels
bug component-platform Portability layer and build scripts

Comments

@simonbutcher
Copy link
Contributor

Description

  • Type: Bug
  • Priority: Minor

@gilles-peskine-arm has raised the following point in review of PR #1454, 'Add a test with a cpp executable including all mbed TLS headers'.

If you run make TEST_CPP=1 and later make clean, then test/cpp_dummy_build doesn't get cleaned. > There's a similar preexisting defect with ssl/ssl_pthread_server. The defect with test/cpp_dummy_build is worse because we include it in our test scripts.

As described by @gilles-peskine-arm, a possible remedy is to:

arrange for make clean to remove test/cpp_dummy_build (and ssl/ssl_pthread_server) regardless of the value of TEST_CPP;

Note, this is an issue for a PR that hasn't yet been merged at the time of writing.
@simonbutcher simonbutcher added bug tracking component-platform Portability layer and build scripts labels Jul 16, 2018
@simonbutcher simonbutcher mentioned this issue Jul 16, 2018
Merged
@ciarmcom
Copy link

ARM Internal Ref: IOTSSL-2395

Patater added a commit to Patater/mbedtls that referenced this issue Jun 19, 2019
@Patater
programs: Make make clean clean all programs always
6109c88 
If `make TEST_CPP:=1` is run, and then `make clean` (as opposed to `make
TEST_CPP:=1 clean`), the cpp_dummy_build will be left behind after the
clean. Make `make clean more convenient to use by removing programs that
could be generated from any configuration, not just the active one.

Fixes Mbed-TLS#1862
Patater added a commit to Patater/mbedtls that referenced this issue Jun 19, 2019
@Patater
programs: Make make clean clean all programs always
f2649cc 
If `make TEST_CPP:=1` is run, and then `make clean` (as opposed to `make
TEST_CPP:=1 clean`), the cpp_dummy_build will be left behind after the
clean. Make `make clean more convenient to use by removing programs that
could be generated from any configuration, not just the active one.

Fixes Mbed-TLS#1862
Patater added a commit to Patater/mbedtls that referenced this issue Jun 20, 2019
@Patater
programs: Make make clean clean all programs always
a1ab6fe 
If `make TEST_CPP:=1` is run, and then `make clean` (as opposed to `make
TEST_CPP:=1 clean`), the cpp_dummy_build will be left behind after the
clean. Make `make clean more convenient to use by removing programs that
could be generated from any configuration, not just the active one.

Fixes Mbed-TLS#1862
Patater added a commit to Patater/mbedtls that referenced this issue Jun 20, 2019
@Patater
programs: Make make clean clean all programs always
0c42e90 
If `make TEST_CPP:=1` is run, and then `make clean` (as opposed to `make
TEST_CPP:=1 clean`), the cpp_dummy_build will be left behind after the
clean. Make `make clean more convenient to use by removing programs that
could be generated from any configuration, not just the active one.

Fixes Mbed-TLS#1862
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug component-platform Portability layer and build scripts
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonbutcher @ciarmcom