polarssl-1.3.2/library/x509_crt.c:1276: 2 * possible bad if test ?

[dcb314]

I just compiled polarssl-1.3.2 with Linux gcc compiler flag -Wlogical-op.
It said

polarssl-1.3.2/library/x509_crt.c:1276:9: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]
polarssl-1.3.2/library/x509_crt.c:1279:9: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]

Source code is

    if( ( n1[i] >= 'a' || n1[i] <= 'z' ) && ( diff == 0 || diff == 32 ) )
        continue;

    if( ( n1[i] >= 'A' || n1[i] <= 'Z' ) && ( diff == 0 || diff == 32 ) )
        continue;

Suggest swap || for && in the a..z checks.

[pjbakker]

Thanks for the report. A bit more was 'wrong'. No impact for current use.
Fixed in our branch for the next release.