"Never return 'WOULD BLOCK' on a non-blocking socket"

[github-monoculture]

Comment seen in net_would_block()

[ciarmcom]

ARM Internal Ref: IOTSSL-863

[pjbakker]

Can you explain what you issue is here?
The comment is there indeed.

[harmv]

I guess the reporter meant this typo in the comments.

static int net_would_block( const mbedtls_net_context *ctx )
{
    /*
     * Never return 'WOULD BLOCK' on a non-blocking socket
     */
    if( ( fcntl( ctx->fd, F_GETFL ) & O_NONBLOCK ) != O_NONBLOCK )
        return ( 0 );

It should be

@@ -270,11 +290,27 @@ static int net_would_block( const mbedtls_net_context *ctx )
 static int net_would_block( const mbedtls_net_context *ctx )
 {
     /*
-     * Never return 'WOULD BLOCK' on a non-blocking socket
+     * Never return 'WOULD BLOCK' on a blocking socket
      */

[cmorty]

@harmv I agree, that makes perfect sense.