Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doxygen: don't traverse symbolic links #1234

Merged
merged 1 commit into from
Apr 19, 2018
Merged

Doxygen: don't traverse symbolic links #1234

merged 1 commit into from
Apr 19, 2018

Conversation

gilles-peskine-arm
Copy link
Contributor

We don't use symbolic links as part of our build process, so tell
Doxygen not to traverse them. In particular, if I have a symbolic link
to a directory outside the build tree, I don't want Doxygen to follow
it.

Backports: should be applied identically to all versions.

@gilles-peskine-arm
Doxygen: don't traverse symbolic links
11d3cf4 
We don't use symbolic links as part of our build process, so tell
Doxygen not to traverse them. In particular, if I have a symbolic link
to a directory outside the build tree, I don't want Doxygen to follow
it.
@gilles-peskine-arm gilles-peskine-arm added enhancement mbed TLS team needs-review Every commit must be reviewed by at least two team members, labels Dec 22, 2017
mpg
mpg approved these changes Jan 3, 2018
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Apr 16, 2018
Merged
@gilles-peskine-arm gilles-peskine-arm added needs-backports Backports are missing or are pending review and approval. and removed runCI labels Apr 16, 2018
@gilles-peskine-arm
Copy link
Contributor Author

retest

@mpg
Copy link
Contributor

mpg commented Apr 16, 2018

CI issues:

  • timing test failed twice but is known to be flaky (Timing tests are flaky and this is very bad #1517)
  • config.pl baremetal -> Command 'baremetal' not recognised. This will be fixed by merging, since this command has been added in development and 2.7 in the meantime.
    None of these issues is a blocker for merging.

@mpg mpg added approved Design and code approved - may be waiting for CI or backports and removed needs-backports Backports are missing or are pending review and approval. needs-review Every commit must be reviewed by at least two team members, labels Apr 16, 2018
@simonbutcher
Copy link
Contributor

@mpg / @gilles-peskine-arm - Why doesn't this have a mbedtls-2.7 backport? Removing the 'ready for merge' label, pending the answer.

@simonbutcher simonbutcher removed the approved Design and code approved - may be waiting for CI or backports label Apr 17, 2018
@gilles-peskine-arm
Copy link
Contributor Author

@sbutcher-arm This PR was made before 2.7. It applies to both 2.7 and development.

@simonbutcher simonbutcher added approved Design and code approved - may be waiting for CI or backports approved for design labels Apr 17, 2018
@gilles-peskine-arm gilles-peskine-arm merged commit 11d3cf4 into Mbed-TLS:development Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonEld RonEld RonEld approved these changes

@mpg mpg mpg approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gilles-peskine-arm @mpg @simonbutcher @RonEld