Fix alarm(0) failure on mingw32 #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new test for mbedtls_timing_alarm(0) was introduced in PR 1136, which also fixed it on Unix. Apparently test results on MinGW were not checked at that point, so we missed that this new test was also failing on this platform.
mpg
added
bug
mbed TLS team
needs-review
gilles-peskine-arm
approved these changes
Jan 29, 2018
|
@mpg The description does not describe what was the problem with |
|
Note: the test passed on a mingw32 builder (see internal tracker for details). |
mazimkhan
approved these changes
Jan 29, 2018
This was referenced Jan 29, 2018
Patater
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new test for mbedtls_timing_alarm(0) was introduced in PR 1136, which also
fixed it on Unix. Apparently test results on MinGW were not checked at that
point, so we missed that this new test was also failing on this platform.
This PR fixes the function in order to make the new test pass, in a way similar to the fix introduce in by #1136 for Unix.
Status
READY
Requires Backporting
Yes
[x] Mbed TLS 2.1 #1329
[x] Mbed TLS 1.3 #1330