Backport 2.1: Expand i386 all.sh tests to include full configuration ASan builds #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The i386 test builds were only building the default configuration and had no address sanitisation. This commit expands the test configuration to the full configuration in all.sh and builds with ASan for when the test suites are executed.
simonbutcher
added
enhancement
needs-review
simonbutcher
added
needs-work
and removed
needs-review
Patater
previously approved these changes
Jul 21, 2018
RonEld
previously approved these changes
Jul 22, 2018
Added an additional i386 test to all.sh, to allow one test with -O0 which compiles out inline assembly, and one to test with -01 which includes the inline assembly.
The i386 MPI inline assembly code was being incorrectly included when all compiler optimisation was disabled.
simonbutcher
force-pushed
the
i386-all.sh-fix-2.1
branch
from
8d9552e to
e9a437f
Compare
Patater
approved these changes
Jul 23, 2018
dgreen-arm
approved these changes
Jul 23, 2018
simonbutcher
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of PR #1810.
The i386 test builds were only building the default configuration and had no address sanitisation. This pull request expands the test configuration to the full configuration in all.sh and generates ASan builds for test suite execution.
This pull request extends test coverage sufficiently that issue #1550, where the MPI assembly code on i386 which was fundamentally broken, would have been caught.
It also fixes the inline assembly which was previously only being included in builds with no optimisation, which was the opposite of what it should have been doing.
Status
READY
Todos