Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.7: Memory leak in example programs pk_encrypt and pk_decrypt #1978

Merged
merged 5 commits into from
Aug 29, 2018
Merged

Backport 2.7: Memory leak in example programs pk_encrypt and pk_decrypt #1978

merged 5 commits into from
Aug 29, 2018

Conversation

hanno-becker
Copy link

This is the backport of #1129 to Mbed TLS 2.7.

@hanno-becker hanno-becker added bug mbed TLS team needs-review Every commit must be reviewed by at least two team members, component-tls labels Aug 23, 2018
RonEld
RonEld suggested changes Aug 23, 2018
View reviewed changes
Copy link
Contributor

@RonEld RonEld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comments as #1129

@hanno-becker
Copy link
Author

@RonEld Addressed your point. Please re-review.

RonEld
RonEld approved these changes Aug 23, 2018
View reviewed changes
Copy link
Contributor

@RonEld RonEld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I think that it's not good practice to have a %s as format, and send it a string literal, this is pre-existing and should not block the PR

@hanno-becker hanno-becker removed the needs-review Every commit must be reviewed by at least two team members, label Aug 24, 2018
@simonbutcher simonbutcher added the approved Design and code approved - may be waiting for CI or backports label Aug 24, 2018
@simonbutcher simonbutcher merged commit 063c50d into Mbed-TLS:mbedtls-2.7 Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonEld RonEld RonEld approved these changes

@andresag01 andresag01 andresag01 approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports bug component-tls
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hanno-becker @andresag01 @RonEld @simonbutcher