Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.7: Improve documentation of mbedtls_ssl_get_verify_result() #2153

Merged
merged 2 commits into from
Nov 8, 2018
Merged

Backport 2.7: Improve documentation of mbedtls_ssl_get_verify_result() #2153

merged 2 commits into from
Nov 8, 2018

Conversation

hanno-becker
Copy link

This is the backport to Mbed TLS 2.7 of #2127, fixing #517.

@hanno-becker hanno-becker added bug mbed TLS team needs-review Every commit must be reviewed by at least two team members, component-tls labels Oct 30, 2018
@hanno-becker hanno-becker mentioned this pull request Oct 30, 2018
Merged
AndrzejKurek
AndrzejKurek previously approved these changes Oct 30, 2018
View reviewed changes
k-stachowiak
k-stachowiak previously approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@k-stachowiak k-stachowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest adding a change log entry here and in the other PRs introducing this change.

@hanno-becker
Copy link
Author

@k-stachowiak Thanks for noticing, I agree and pushed a commit adapting the ChangeLog.

@k-stachowiak @AndrzejKurek Please re-review.

@hanno-becker hanno-becker removed the needs-review Every commit must be reviewed by at least two team members, label Nov 6, 2018
@simonbutcher simonbutcher added the approved Design and code approved - may be waiting for CI or backports label Nov 6, 2018
@simonbutcher simonbutcher merged commit 0b0753c into Mbed-TLS:mbedtls-2.7 Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrzejKurek AndrzejKurek AndrzejKurek approved these changes

@k-stachowiak k-stachowiak k-stachowiak approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports bug component-tls
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hanno-becker @k-stachowiak @AndrzejKurek @simonbutcher