Remove "mbedtls/" prefix in include file path #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amisare
changed the title
RonEld
added
CLA requested
component-crypto
RonEld
suggested changes
Jan 3, 2019
simonbutcher
previously approved these changes
Jan 3, 2019
ChangeLog
Outdated
|
|
||
| Bugfix | ||
| * Fix for file not found, which was reporting in header files. | ||
| In header files at mbedlts/include folder, The include path has prefix |
There was a problem hiding this comment.
Typo. Should be 'include/mbedtls', and 'the' shouldn't be capitalised. Not a blocker and can be fixed in merge.
ChangeLog
Outdated
| * Fix for file not found, which was reporting in header files. | ||
| In header files at mbedlts/include folder, The include path has prefix | ||
| "mbedtls/" may cause the header file not be found in the case of | ||
| mbedtls as a dynamic/static library. |
There was a problem hiding this comment.
Need to credit @amisare. Not a blocker and can be fixed in merge.
|
@RonEld - I can fix the ChangeLog in merge. If you see nothing else as wrong, can you please approve? Thanks. |
|
Needs backporting, but the same PR can be used on branch 2.16. |
Co-Authored-By: amisare <243297288@qq.com>
|
@RonEld @sbutcher-arm I try to fix the ChangeLog. if it still has some error, you can modify it according to your rules. |
RonEld
approved these changes
Jan 6, 2019
4 tasks
AndrzejKurek
approved these changes
Jan 9, 2019
simonbutcher
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Additional comments
Fix for file not found, which was reporting in header files. In header files at mbedlts/include folder, The include path has prefix "mbedtls/" may cause the header file not be found in the case of mbedtls as a dynamic/static library.
Todos