Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.16: Fix signed-to-unsigned integer conversion warning in X.509 module #2347

Merged
merged 2 commits into from
Jan 31, 2019
Merged

Backport 2.16: Fix signed-to-unsigned integer conversion warning in X.509 module #2347

merged 2 commits into from
Jan 31, 2019

Conversation

hanno-becker
Copy link

This is the backport to Mbed TLS 2.16 of #2213, fixing #2212.

Hanno Becker added 2 commits January 10, 2019 09:23
Avoid MSVC compiler warning
d6ddcd6 
MSVC warns about use of unary `-` operator on unsigned integers.
Adapt ChangeLog
47da6df
@hanno-becker hanno-becker added bug mbed TLS team needs-review Every commit must be reviewed by at least two team members, component-x509 labels Jan 10, 2019
@hanno-becker hanno-becker changed the base branch from development to mbedtls-2.16 January 10, 2019 09:27
mpg
mpg approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Though I don't think a backport was necessary in this case, as there is nothing in development yet that won't go in 2.16 as well, since this PR is already here, I'm approving it.

@hanno-becker hanno-becker removed the needs-review Every commit must be reviewed by at least two team members, label Jan 14, 2019
@hanno-becker
Copy link
Author

Ping @sbutcher-arm for gatekeeping.

@simonbutcher simonbutcher added the approved Design and code approved - may be waiting for CI or backports label Jan 27, 2019
@Patater Patater merged commit 47da6df into Mbed-TLS:mbedtls-2.16 Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrzejKurek AndrzejKurek AndrzejKurek approved these changes

@mpg mpg mpg approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports bug component-x509
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hanno-becker @mpg @AndrzejKurek @Patater @simonbutcher