Backport 2.16: Reduce Stack usage of hkdf test function #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 17, 2019 21:31
`test_hkdf` in the hkdf test suites consumed stack of ~6KB with 6 buffers of ~1KB each. This causes stack overflow on some platforms with smaller stack. The buffer sizes were reduced. By testing, the sizes can be reduced even further, as the largest seen size is 82 bytes(for okm).
Reduce the buffer size of okm to 128, to reduce stack usage.
Add ChangeLog entry describing the fix.
RonEld
added
bug
mbed TLS team
needs-review
4 tasks
hanno-becker
previously approved these changes
Jan 28, 2019
added 2 commits
January 28, 2019 15:05
Add explanation for why the size of `okm_string` buffer is twice as `okm` buffer.
1. Fix comment grammar. 2. Rename `okm_string` to `okm_hex`.
Add an additional byte for the `okm_hex` buffer, to assure it is null-terminated in case `okm` is 128 bytes long.
andresag01
approved these changes
Feb 13, 2019
|
@hanno-arm could you review the last commits since your previous review? or @AndrzejKurek could you review it? (Please coordinate to avoid duplicated work!) This second review is the last thing holding back this backport and its parent PR. Thanks! |
AndrzejKurek
approved these changes
Mar 1, 2019
RonEld
removed
the
needs-review
RonEld
changed the title
|
Approved and passing all CI, so labelling as 'ready for merge'. |
simonbutcher
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #2192 to
mbedtls-2.16Status
READY