Backport 2.16: Fix dead code in mbedtls_mpi_exp_mod() #2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
AndrzejKurek
previously approved these changes
Jan 30, 2019
RonEld
added
bug
CLA valid
needs-review
RonEld
previously approved these changes
Jan 30, 2019
RonEld
removed
the
needs-review
Patater
added
the
approved
|
Please rebase to update for all.sh changes. |
In mbedtls_mpi_exp_mod(), the limit check on wsize is never true when MBEDTLS_MPI_WINDOW_SIZE is at least 6. Wrap in a preprocessor guard to remove the dead code and resolve a Coverity finding from the DEADCODE checker. Change-Id: Ice7739031a9e8249283a04de11150565b613ae89
There were no tests for a non-default MPI window size. Add one. Change-Id: Ic08fbc9161d0b3ee67eb3c91f9baf602646c9dfe
k-stachowiak
dismissed stale reviews from RonEld and AndrzejKurek
via
1e2aa72
k-stachowiak
force-pushed
the
mpi-deadcode-2.16
branch
from
01a3521 to
1e2aa72
Compare
|
@Patater I have rebased the PR. |
RonEld
previously approved these changes
Feb 5, 2019
pkolbus
suggested changes
Feb 9, 2019
ChangeLog
Outdated
| @@ -31,6 +31,10 @@ Changes | |||
| Inserted as an enhancement for #1371 | |||
| * Add support for alternative CSR headers, as used by Microsoft and defined | |||
| in RFC 7468. Found by Michael Ernst. Fixes #767. | |||
| * Remove dead code from bignum.c in the default configuration. | |||
| Found by Coverity, reported and fixed by Peter Kolbus. Fixes #2309. | |||
There was a problem hiding this comment.
Please credit my employer as well: "Peter Kolbus (Garmin)"
There was a problem hiding this comment.
Done. Thanks for a quick response!
k-stachowiak
force-pushed
the
mpi-deadcode-2.16
branch
2 times, most recently
from
0d48080 to
b17ac5b
Compare
k-stachowiak
force-pushed
the
mpi-deadcode-2.16
branch
from
b17ac5b to
dc5893d
Compare
|
@AndrzejKurek @RonEld Could you please review the change log update? |
AndrzejKurek
approved these changes
Feb 11, 2019
hanno-becker
approved these changes
Feb 11, 2019
|
Thanks, LGTM. |
RonEld
approved these changes
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #2317