Add guards for MBEDTLS_X509_CRL_PARSE_C in sample #2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add checks in `ssl_server2` that `MBEDTLS_X509_CRL_PARSE_C` is defined to fix compilation issue. Fixes Mbed-TLS#560.
RonEld
added
bug
mbed TLS team
needs-review
This was referenced Apr 4, 2019
RonEld
added
the
needs-backports
andresag01
approved these changes
Apr 8, 2019
| @@ -729,6 +741,7 @@ sni_entry *sni_parse( char *sni_string ) | |||
| if( mbedtls_x509_crl_parse_file( new->crl, crl_file ) != 0 ) | |||
| goto error; | |||
| } | |||
| #endif | |||
There was a problem hiding this comment.
Minor: Please add the matching #endif comment /* MBEDTLS_X509_CRL_PARSE_C */. There are also a few other places where this happens.
k-stachowiak
approved these changes
Apr 18, 2019
RonEld
removed
needs-backports
|
Both backports have been fully reviewed and approved, so removing the "needs backports" label. |
Patater
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add checks in
ssl_server2thatMBEDTLS_X509_CRL_PARSE_Cis definedto fix compilation issue. Fixes #560.
Status
READY
Requires Backporting
Yes
Additional comments
MBEDTLS_X509_CRT_PARSE_CandMBEDTLS_PK_C), but both of the are dependencies, wither direct or indirect ofMBEDTLS_SSL_SERVER_NAME_INDICATIONcausingcheck_config.hto fail, so no problem in this case.Todos
Steps to test or reproduce
MBEDTLS_X509_CRL_PARSE_Cin the configuration