Fix mpi_bigendian_to_host() on bigendian systems that don't have BYTE_ORDER defined #2623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation of mpi_bigendian_to_host() did a byte-swapping regardless of the endianness of the system. Fixes Mbed-TLS#2622.
hanno-becker
added
bug
mbed TLS team
needs-work
needs-review
|
@mrpippy How would you like to be credited in the ChangeLog? |
|
"Brendan Shanks" is fine, thanks! |
|
Question: do we already have backlog item to add a big-endian architecture to our CI? cc @Patater |
|
@mrpippy Could you please confirm this patch works for you? Thanks. |
|
Looks good, all tests pass on big-endian PowerPC |
Patater
added
the
needs-backports
|
I believe this needs a Mbed TLS 2.16 backport, as the implementation of |
Patater
removed
the
needs-review
|
Backport available here: #2645. |
Patater
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of
mpi_uint_bigendian_to_host_c()did a byte-swapping regardless of the endianness of the system. Fixes #2622 found by @mrpippy.Still needs a ChangeLog entry.