Backport 2.16: Fix minor defects found by Coverity #3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilles-peskine-arm
added
bug
mbed TLS team
needs-review
mpg
requested changes
Jan 27, 2020
There was a problem hiding this comment.
I reviewed with the following criteria in mind:
- The backported commits are faithful to the original commits.
- The commits that are not backported are not relevant to this branch.
- The commits that are backported are relevant to this branch.
I'm happy with respect to the first two criteria, but I think I found an issue regarding the third.
For the record, here's my reasoning regarding excluded commits:
- fix file leak in program: 2.16 doesn't have nss keylog in ssl_client2.c
- get_len_step: 2.16 doesn't have test_suite_asn1parse
- ASSERT_ALLOC_WEAK: 2.16 doesn't have that macro
tests/suites/host_test.function
Outdated
| @@ -431,6 +431,15 @@ int execute_tests( int argc , const char ** argv ) | |||
| return( 1 ); | |||
| } | |||
|
|
|||
| if( outcome_file_name != NULL ) | |||
There was a problem hiding this comment.
It seems to me that this file did not have any reference to outcome_file_name in mbedtls-2.16 before thie PR, and the compiler would seem to agree:
suites/host_test.function: In function 'execute_tests':
suites/host_test.function:434:9: error: 'outcome_file_name' undeclared (first use in this function)
if( outcome_file_name != NULL )
Should this commit be skipped in the 2.16 backport?
There was a problem hiding this comment.
Indeed. CI also rejects this commit. I force-pushed a new history without that commit.
Check the value only once, as soon as we've obtained it.
gilles-peskine-arm
force-pushed
the
coverity-20200115-2.16
branch
from
7f2b966 to
75aab52
Compare
mpg
approved these changes
Jan 28, 2020
yanesca
approved these changes
Jan 28, 2020
yanesca
removed
needs-ci
mpg
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straightforward backport of the applicable parts of ARMmbed/mbed-crypto#349 and #2995