Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.16] Fix contributor names in ChangeLog #3014

Merged
merged 2 commits into from
Jan 29, 2020
Merged

[2.16] Fix contributor names in ChangeLog #3014

merged 2 commits into from
Jan 29, 2020

Conversation

mpg
Copy link
Contributor

@mpg mpg commented Jan 29, 2020

Follow-up to #3007

@mpg mpg added mbed TLS team needs-review Every commit must be reviewed by at least two team members, labels Jan 29, 2020
@mpg mpg mentioned this pull request Jan 29, 2020
Merged
1 task
Patater
Patater previously approved these changes Jan 29, 2020
View reviewed changes
yanesca
yanesca requested changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-existing: The automatic merge of the changelog didn't go well, I think we could fix that too in this PR. (For example by deleting lines 8-9.)

@mpg
Copy link
Contributor Author

mpg commented Jan 29, 2020

@yanesca Thanks for catching! I fixed that in a new commit.

@mpg mpg requested review from yanesca and Patater January 29, 2020 10:38
yanesca
yanesca approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@yanesca yanesca added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Jan 29, 2020
@yanesca yanesca merged commit 1f10f2e into Mbed-TLS:mbedtls-2.16 Jan 29, 2020
@mpg mpg deleted the fix-attribution-ecdsa-inc branch August 14, 2020 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanesca yanesca yanesca approved these changes

@Patater Patater Patater approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpg @Patater @yanesca