Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 2.7: adjusting size of sliding window array to correct size #3652

Merged
merged 4 commits into from
Sep 9, 2020

Conversation

d-otte
Copy link
Contributor

@d-otte d-otte commented Sep 8, 2020

Backport of #3592 to the mbedtls-2.7 branch.

Probably the `W[2 << MBEDTLS_MPI_WINDOW_SIZE]` notation is based on a transcription of 2**MBEDTLS_MPI_WINDOW_SIZE.

Signed-off-by: Daniel Otte <d.otte@wut.de>
Signed-off-by: Daniel Otte <d.otte@wut.de>
The comment now uses '**' as exponentiation operator.

Signed-off-by: Daniel Otte <d.otte@wut.de>
Signed-off-by: Daniel Otte <d.otte@wut.de>
@d-otte d-otte changed the title Backport of #3592 to mbedtls-2.7 (adjusting size of sliding window array to correct size) Backport 2.7: adjusting size of sliding window array to correct size Sep 8, 2020
@gilles-peskine-arm gilles-peskine-arm added component-crypto Crypto primitives and low-level interfaces enhancement needs-review Every commit must be reviewed by at least two team members, labels Sep 8, 2020
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpg mpg added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Sep 9, 2020
@mpg mpg merged commit 5796dfe into Mbed-TLS:mbedtls-2.7 Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Design and code approved - may be waiting for CI or backports component-crypto Crypto primitives and low-level interfaces enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants