Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error code when creating/registering a key with invalid id #4279

Merged
merged 7 commits into from
Apr 6, 2021
Merged

Fix error code when creating/registering a key with invalid id #4279

merged 7 commits into from
Apr 6, 2021

Conversation

ronald-cron-arm
Copy link
Contributor

Description

Fix 4271

Status

READY

Requires Backporting

No PSA only

@ronald-cron-arm ronald-cron-arm linked an issue Apr 1, 2021 that may be closed by this pull request
Fix return value for psa_copy_key() if lifetime or identifier in attributes is invalid. #4271
Closed
@ronald-cron-arm ronald-cron-arm added component-psa PSA keystore/dispatch layer (storage, drivers, …) enhancement needs-ci Needs to pass CI tests PSA compliance labels Apr 1, 2021
@gabor-mezei-arm gabor-mezei-arm self-requested a review April 1, 2021 08:15
@ronald-cron-arm ronald-cron-arm changed the title Fix invalid id error code Fix error code when creating/registering a key with invalid id Apr 1, 2021
@ronald-cron-arm ronald-cron-arm mentioned this pull request Apr 1, 2021
Merged
@ronald-cron-arm
psa: Fix psa_validate_key_persistence documentation
de825e6 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
tests: psa: Add negative tests for psa_copy_key()
88a5546 
Add negative tests checking that psa_copy_key()
returns PSA_ERROR_INVALID_ARGUMENT when passed in
an invalid key identifier or key lifetime for the
target key.

Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
psa: Fix error code when creating/registering a key with invalid id
77e412c 
When creating a persistent key or registering a key
with an invalid key identifier return
PSA_ERROR_INVALID_ARGUMENT instead of
PSA_ERROR_INVALID_HANDLE.

Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm ronald-cron-arm force-pushed the fix-invalid-id-error-code branch from d8e50a2 to a0fe19c Compare April 1, 2021 12:43
@ronald-cron-arm
tests: psa: Fix expected error code
d3b458c 
Fix expected error code when importing a persistent key or
registering a key with an invalid key identifier:
PSA_ERROR_INVALID_ARGUMENT instead of PSA_ERROR_INVALID_HANDLE.

Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
Add change log
602f986 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm ronald-cron-arm force-pushed the fix-invalid-id-error-code branch from a0fe19c to 602f986 Compare April 1, 2021 12:55
@ronald-cron-arm ronald-cron-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review and removed needs-ci Needs to pass CI tests labels Apr 1, 2021
gilles-peskine-arm
gilles-peskine-arm requested changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a one-bit copypasta in a test case. Other than that LGTM

tests/suites/test_suite_psa_crypto.data Outdated Show resolved Hide resolved
@ronald-cron-arm
tests: psa: Fix copy fail test argument
a0bc2cd 
Fix copy fail test argument for only one of them
to be invalid.

Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
psa: Return in error when requested to copy a key to an opaque driver
6cc6631 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@gabor-mezei-arm gabor-mezei-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Apr 6, 2021
@gilles-peskine-arm gilles-peskine-arm merged commit 889828d into Mbed-TLS:development Apr 6, 2021
daverodgman pushed a commit that referenced this pull request Apr 23, 2021
@gilles-peskine-arm
Merge pull request #4279 from ronald-cron-arm/fix-invalid-id-error-code
0dabd6a 
Fix error code when creating/registering a key with invalid id
@ManojKrSrivastava ManojKrSrivastava mentioned this pull request May 13, 2022
Closed
@ronald-cron-arm ronald-cron-arm deleted the fix-invalid-id-error-code branch July 21, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabor-mezei-arm gabor-mezei-arm gabor-mezei-arm approved these changes

@gilles-peskine-arm gilles-peskine-arm gilles-peskine-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-psa PSA keystore/dispatch layer (storage, drivers, …) enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix return value for psa_copy_key() if lifetime or identifier in attributes is invalid.
3 participants
@ronald-cron-arm @gilles-peskine-arm @gabor-mezei-arm