Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make check-names.sh accept any grep #4309

Merged

Conversation

daverodgman
Copy link
Contributor

check-names.sh works fine with GNU and with modern FreeBSD grep
so remove the check for GNU grep.

Signed-off-by: Dave Rodgman dave.rodgman@arm.com

Backport of #4308

check-names.sh works fine with GNU and with modern FreeBSD grep
so remove the check for GNU grep.

Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
@daverodgman daverodgman added enhancement needs-review Every commit must be reviewed by at least two team members, labels Apr 7, 2021
@gilles-peskine-arm gilles-peskine-arm added the needs-backports Backports are missing or are pending review and approval. label Apr 7, 2021
@daverodgman daverodgman added the needs-reviewer This PR needs someone to pick it up for review label Apr 7, 2021
@daverodgman daverodgman added the size-s Estimated task size: small (~2d) label Apr 7, 2021
@gilles-peskine-arm
Copy link
Contributor

The backports are trivial so can be merged with a single approval, but I'd prefer a third pair of eyes on the change, so I'm keeping "needs: reviewer" on the main PR.

@ronald-cron-arm ronald-cron-arm self-requested a review April 7, 2021 14:25
@daverodgman daverodgman merged commit 0708974 into Mbed-TLS:development Apr 7, 2021
@daverodgman daverodgman deleted the check-names-grep-backport branch April 7, 2021 14:29
daverodgman added a commit that referenced this pull request Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs-backports Backports are missing or are pending review and approval. needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants