Backport 2.x: Fix missing compilation guard around psa_crypto_driver_wrappers.c #4412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilles-peskine-arm
added
bug
mbed TLS team
needs-review
gilles-peskine-arm
added
the
needs-backports
gilles-peskine-arm
changed the title
Fix Mbed-TLS#4411. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
force-pushed
the
undefined-reference-2.27
branch
from
d639bba to
ad0e012
Compare
|
I rebased the commit because there was a merge conflict, and opened a 3.0 PR. |
ronald-cron-arm
approved these changes
May 20, 2021
gilles-peskine-arm
removed
needs-backports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4411.
No non-regression because I'd like a discussion on how to do it. Replace some/most static builds by shared builds? Do both a static and a shared build? I filed the wish for testing at #4545.
3.0 version