Fix parameter set but unused on psa_cipher_update_ecb #4938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
added
bug
needs-review
This parameter was set but not used, which was pointless. Clang 14 detects this and legitimately complains. Remove the parameter. This is an internal function, only called once. The caller already has a sufficient check on the output buffer size which applies in more cases, so there is no real gain in robustness in adding the same check inside the internal function. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
force-pushed
the
psa_cipher_update_ecp-unused_parameter
branch
from
803baa4 to
1716f32
Compare
yanesca
reviewed
Sep 13, 2021
|
Thanks Gilles for working on this fix |
mpg
requested changes
Sep 13, 2021
library/psa_crypto_cipher.c
Outdated
| * it is stored in \p ctx for future processing. | ||
| * \param output The buffer where the output is written. | ||
| * \param output_size The size of \p output in bytes. | ||
| * It must be at least `floor((p + input_length) / BS)` |
There was a problem hiding this comment.
That doesn't look right; did you mean to multiply by BS at the end?
There was a problem hiding this comment.
Oops. I started to write the size in blocks, but then thought that bytes would be clearer, but then I forgot to multiply.
mpg
added
needs-work
and removed
needs-review
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
added
needs-review
yanesca
removed
the
needs-review
yanesca
removed
the
needs-backports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4935. The only compiler known to complain so far is the development version of Clang (to be released as Clang 14), which oss-fuzz just switched to.
Needs backport: 2.x