Work around bad code generation with clang at -O2 #4945
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions of clang from around 12 seem to generate code badly in mpi_mul_hlp(), causing the mpi tests to fail. Setting __attribute__ ((noinline)) fixes this issue. Signed-off-by: David Horstmann <david.horstmann@arm.com>
gilles-peskine-arm
requested changes
Sep 14, 2021
There was a problem hiding this comment.
As I wrote in #4786 (comment), there is actually a genuine bug in our code. I made a fix in #4941.
|
This is properly fixed by #4941 and its forward ports |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions of clang from around 12 seem to generate code
badly in
mpi_mul_hlp(), causing the mpi tests to fail.Setting
__attribute__ ((noinline))fixes this issue.Signed-off-by: David Horstmann david.horstmann@arm.com
Description
Fixes #4786
This works around bad code generation with clang-12 onwards, in
mpi_mul_hlp(). We already work around code generation issues with clang on some platforms using__attribute__ ((noinline)), so this PR extends that workaround to all versions of clang.Status
READY
Requires Backporting
Yes
Which branch?
Migrations
If there is any API change, what's the incentive and logic for it.
NO
Todos