Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the PSA_ALG_RSA_PSS salt length documentation #4949

Closed
wants to merge 1 commit into from
Closed

Fix the PSA_ALG_RSA_PSS salt length documentation #4949

wants to merge 1 commit into from

Conversation

gilles-peskine-arm
Copy link
Contributor

Modify the documentation of the salt length for PSA_ALG_RSA_PSS. The new documentation matches the actual behavior of the library. It also matches the upcoming version (1.0.2) of the PSA Crypto API specification (internal link: https://github.com/ARM-software/psa-crypto-api/pull/505).

Needs backport: 2.2x

@gilles-peskine-arm
Fix the PSA_ALG_RSA_PSS salt length documentation
1500e36 
Modify the documentation of the salt length for PSA_ALG_RSA_PSS. The new
documentation matches the actual behavior of the library. It also matches
the upcoming version (1.0.2) of the PSA Crypto API specification.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm gilles-peskine-arm added bug component-crypto Crypto primitives and low-level interfaces PSA compliance labels Sep 15, 2021
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Sep 15, 2021
Closed
akshayupendran
akshayupendran approved these changes Sep 15, 2021
View reviewed changes
Copy link

@akshayupendran akshayupendran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation now better describes the verification scenario. Thanks for the update.

@gilles-peskine-arm
Copy link
Contributor Author

Since the PSA specification is going to evolve in a different route, Mbed TLS will need to change its behavior to match the documentation, not the other way round.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayupendran akshayupendran akshayupendran approved these changes

Assignees
No one assigned
Labels
bug component-crypto Crypto primitives and low-level interfaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gilles-peskine-arm @akshayupendran