Fix aarch64 assembly for bignum multiplication #4968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add memory constraints to the aarch64 inline assembly in MULADDC_STOP. This fixes an issue where Clang 12 and 13 were generating non-functional code on aarch64 platforms. See Mbed-TLS#4962, Mbed-TLS#4943 for further details. Signed-off-by: David Horstmann <david.horstmann@arm.com>
davidhorstmann-arm
added
bug
component-crypto
xffbai
previously approved these changes
Sep 24, 2021
gilles-peskine-arm
removed
the
needs-reviewer
gilles-peskine-arm
previously approved these changes
Sep 24, 2021
| @@ -0,0 +1,4 @@ | |||
| Bugfix | |||
| * Add missing memory constraints in aarch64 inline assembly for | |||
There was a problem hiding this comment.
We probably should combine the two changelog entries that concern the same bug on different architectures.
gilles-peskine-arm
removed
the
needs-review
Combine the changelog entries for the memory constraints fix on aarch64 and amd64, since these are essentially fixing the same issue. Signed-off-by: David Horstmann <david.horstmann@arm.com>
davidhorstmann-arm
dismissed stale reviews from gilles-peskine-arm and xffbai
via
7500a0e
gilles-peskine-arm
approved these changes
Sep 24, 2021
gilles-peskine-arm
added
needs-review
xffbai
approved these changes
Sep 27, 2021
gilles-peskine-arm
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing memory constraint in aarch64 bignum multiplication code to remedy Clang 12+ issues. Fixes #4962.
Part of the larger super-issue #4943.
Tested with the following steps:
Status
READY
Requires Backporting
Yes
Only to 2.x as
2.16does not have this aarch64 assembly