Additional cipher_info getters #5149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Fillinger <max@max-fillinger.net>
Signed-off-by: Max Fillinger <max@max-fillinger.net>
mfil
force-pushed
the
feature/additional_cipher_info_getters
branch
from
0e9df7f to
01bd69b
Compare
Signed-off-by: Max Fillinger <max@max-fillinger.net>
Signed-off-by: Max Fillinger <max@max-fillinger.net>
mfil
force-pushed
the
feature/additional_cipher_info_getters
branch
from
01bd69b to
7568d1a
Compare
gabor-mezei-arm
added
Community
component-crypto
gilles-peskine-arm
requested changes
Nov 18, 2021
gilles-peskine-arm
added
needs-work
and removed
needs-review
Signed-off-by: Max Fillinger <max@max-fillinger.net>
- Document unit (bytes) - Explain what happens for stream ciphers Signed-off-by: Max Fillinger <max@max-fillinger.net>
mfil
force-pushed
the
feature/additional_cipher_info_getters
branch
from
66acc93 to
e85bb70
Compare
gilles-peskine-arm
previously approved these changes
Nov 23, 2021
gilles-peskine-arm
added
needs-review
davidhorstmann-arm
requested changes
Nov 23, 2021
daverodgman
removed
the
needs-reviewer
daverodgman
added
needs-work
and removed
needs-review
Signed-off-by: Max Fillinger <max@max-fillinger.net>
Signed-off-by: Max Fillinger <max@max-fillinger.net>
mfil
force-pushed
the
feature/additional_cipher_info_getters
branch
from
92886bb to
72abd8a
Compare
davidhorstmann-arm
approved these changes
Nov 29, 2021
gilles-peskine-arm
approved these changes
Dec 3, 2021
gilles-peskine-arm
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While trying to add mbedtls 3 support to OpenVPN, we found that we need some additional getter functions that are not yet in the dev branch. This pull request adds functions that get the IV and block size from a
cipher_infostruct and functions that check if the IV or key size of a cipher are variable.We also need some more getter functions in other parts of the library, but I figured it's easier if I keep the pull requests small.
Status
READY
Requires Backporting
NO
Migrations
NO
Todos