Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Move base64 constant-time functions to the new module #5284

Merged
merged 9 commits into from
Dec 9, 2021
Merged

[Backport 2.x] Move base64 constant-time functions to the new module #5284

merged 9 commits into from
Dec 9, 2021

Conversation

gabor-mezei-arm
Copy link
Contributor

Backport of #5236
No changes made to the original PR.

Description

The goal of this task is to move base64 constant-time functions to the new constant-time module.

resolves #4926

@gabor-mezei-arm
Rename functions to have suitable name
7464f37 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
@gabor-mezei-arm
Move mbedtls_ct_uchar_mask_of_range function to the constant-time module
46f79c3 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
@gabor-mezei-arm
Move mbedtls_ct_base64_enc_char function to the constant-time module
200708d 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
@gabor-mezei-arm
Move mbedtls_ct_base64_dec_value function to the constant-time module
3d4dba8 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
@gabor-mezei-arm
Delete base64_invasive.h due to functions are moved to the constant-t…
f554ce2 
…ime module

Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
@gabor-mezei-arm
Make mbedtls_ct_uchar_mask_of_range function static
df29332 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
@gabor-mezei-arm
Unify function parameters
46ca2f7 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
@gabor-mezei-arm
Add documentation for the functions
3a755f5 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
@gabor-mezei-arm gabor-mezei-arm added enhancement component-crypto Crypto primitives and low-level interfaces labels Dec 8, 2021
@gabor-mezei-arm gabor-mezei-arm self-assigned this Dec 8, 2021
@gabor-mezei-arm gabor-mezei-arm added needs-ci Needs to pass CI tests needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review and removed needs-reviewer This PR needs someone to pick it up for review labels Dec 8, 2021
davidhorstmann-arm
davidhorstmann-arm previously approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

mpg
mpg requested changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the backport, but the CI points out that in 2.x we need to update the generated files.

@mpg mpg mentioned this pull request Dec 8, 2021
Merged
3 tasks
@mpg mpg added needs-work and removed needs-review Every commit must be reviewed by at least two team members, labels Dec 8, 2021
@gabor-mezei-arm
Update generated files
00e08a3 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
@mpg mpg added needs-review Every commit must be reviewed by at least two team members, and removed needs-work labels Dec 9, 2021
mpg
mpg approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

davidhorstmann-arm
davidhorstmann-arm approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpg mpg added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests labels Dec 9, 2021
@mpg mpg merged commit 218abe0 into Mbed-TLS:development_2.x Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhorstmann-arm davidhorstmann-arm davidhorstmann-arm approved these changes

@mpg mpg mpg approved these changes

Assignees

@gabor-mezei-arm gabor-mezei-arm

Labels
approved Design and code approved - may be waiting for CI or backports component-crypto Crypto primitives and low-level interfaces enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabor-mezei-arm @mpg @davidhorstmann-arm