List ssl_debug_helpers_generated.h in generated files #5329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilles-peskine-arm
added
bug
needs-review
mpg
requested changes
Dec 13, 2021
| @@ -118,7 +118,7 @@ check() | |||
| check scripts/generate_errors.pl library/error.c | |||
| check scripts/generate_query_config.pl programs/test/query_config.c | |||
| check scripts/generate_features.pl library/version_features.c | |||
| check scripts/generate_ssl_debug_helpers.py library/ssl_debug_helpers_generated.c | |||
| check scripts/generate_ssl_debug_helpers.py library/ssl_debug_helpers_generated.hc library/ssl_debug_helpers_generated.c | |||
There was a problem hiding this comment.
Well, nope, the CI points out a typo: .hc
gilles-peskine-arm
force-pushed
the
ssl_debug_helpers_generated.h-dependencies
branch
from
f113549 to
12e27d4
Compare
Running `generate_ssl_debug_helpers.py` generates both `ssl_debug_helpers_generated.c` and `ssl_debug_helpers_generated.h`. List the `.h` file as well as the `.c` file in `check-generated-files.sh` so that `check-generated-files.sh -u` will complain if it isn't up to date. List it in `Makefile` and `CMakeLists.txt` so that parallel builds know when to wait until the `.h` file is present. In `Makefile`, declare the `.c` file as depending on the `.h` file for order. This way, a dependency for either will wait until the `.h` file is present, and since the `.h` file is generated after the `.c` file, this guarantees that the `.c` file is present. This fixes random failures of `make -j` from a fresh checkout. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
yuhaoth
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix intermittent failure of parallel builds from a fresh checkout, as seen recently in the
code-coveragenightly CI job (https://jenkins-mbedtls.oss.arm.com/job/mbed-tls-nightly-tests/2281/, https://jenkins-mbedtls.oss.arm.com/job/mbed-tls-nightly-tests/2284/).A few code-coverage runs to test: 1 2 3
Not applicable to older branches.