Coverage improvements #540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| TEST_ASSERT ( 0 == mbedtls_md_update( &ctx_copy, src_str + halfway, src_len - halfway ) ); | ||
| TEST_ASSERT ( 0 == mbedtls_md_finish( &ctx_copy, output ) ); | ||
| hexify( hash_str, output, mbedtls_md_get_size(md_info) ); |
There was a problem hiding this comment.
minor style issue: mbedtls_md_get_size(md_info) -> mbedtls_md_get_size( md_info )
|
+1 |
+13 functions, +57 lines
As a consequence also adds coverage for reading 3 and 4 byte lengths (which were not covered before)
| @@ -1097,3 +1097,6 @@ test_vec_ecb:MBEDTLS_CIPHER_AES_256_ECB:MBEDTLS_DECRYPT:"00000000000000000000000 | |||
| AES-256-ECB Decrypt NIST KAT #12 | |||
| depends_on:MBEDTLS_AES_C | |||
| test_vec_ecb:MBEDTLS_CIPHER_AES_256_ECB:MBEDTLS_DECRYPT:"0000000000000000000000000000000000000000000000000000000000000000":"9b80eefb7ebe2d2b16247aa0efc72f5d":"e0000000000000000000000000000000":0 | |||
|
|
|||
| Cipher Corner Case behaviours | |||
There was a problem hiding this comment.
Looks like this special case should be dependent on MBEDTLS_AES_C.
There was a problem hiding this comment.
Please see line 95 in the patch to test_suit_cipher.function where the dependency is stated..
|
Reviewed, all issues addressed, so ready for merge. |
simonbutcher
added
enhancement
approved
simonbutcher
added a commit
that referenced
this pull request
Dec 4, 2018
Update the library version to 2.14.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverage improvements and some general bug fixes.