Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HKDF (RFC 5869) implementation #542

Closed
wants to merge 16 commits into from

Conversation

thomas-fossati
Copy link
Contributor

Hi,

I've been working with Hannes at the IETF hackathon here in Berlin on the DTLS 1.3 implementation.

Of all the work we've done, I think the implementation of the core HKDF (which is used heavily by the 1.3 key scheduling) is probably something that might be shipped to the dev branch: it's both valid as a standalone primitive and will also be helpful when working on 1.3...

The code is accompanied by a set of test vectors taken from RFC 5869.

(BTW, is there a clang-format/indent file that I can apply to format the sources the mbedtls way?)

@thomas-fossati
Copy link
Contributor Author

The travis checks run successfully, whereas circleci tests fail with a "no test commands were found" reason phrase... I'm not sure I understand what I need to do to make them run? Can someone shed some light on this? Thanks!

@simonbutcher
Copy link
Contributor

Hi and thanks for the contribution!

I can see you've put quite a lot of work into this, so thanks for the interest and support.

First to answer your question about CircleCI - we have several CI systems, and CircleCI is still a work in progress and if you hadn't realised, fails on all builds. Apologies for the confusion. For the moment, just ignore it's results. We work in the open pretty transparently, and that can be very good in some ways, but confusing when you reasonably expect something to work and it's not quite there yet.

So to accept your current contributions or any future contributions we will need a Contributor’s Licence Agreement (CLA) signed or authorised by yourself. You can find an agreement to sign here, which can be signed and returned to us, or you could create an mbed account and accept a slightly different agreement here with a click through if this is a personal contribution.

Thanks for your understanding!

@thomas-fossati
Copy link
Contributor Author

Hi,

thanks for the clarifications. I've just registered as user "babongo" and accepted the Contributor Agreement.

Cheers, t

@Patater
Copy link
Contributor

Patater commented Mar 29, 2018

Hi @thomas-fossati

Thanks for your contribution! I've rebased it on latest development, adapted the style, and made a new PR (#1497) to continue the process of getting your contribution merged. I'll close this PR and we'll continue the work in #1497.

Thanks!

@Patater Patater closed this Mar 29, 2018
@thomas-fossati
Copy link
Contributor Author

My pleasure @Patater !

gilles-peskine-arm pushed a commit to gilles-peskine-arm/mbedtls that referenced this pull request Dec 3, 2018
Update the library version to 2.1.17
iameli pushed a commit to livepeer/mbedtls that referenced this pull request Dec 5, 2023
…totypes_to_satisfy_strict-prototypes_gcc_11_1_1

Add void to function declarations for EVP_EncryptInit check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants