Move client_auth to handshake #5472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable is used for client side only Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
yuhaoth
added
needs-ci
|
ABI-API-checking fail only |
mpg
previously approved these changes
Jan 28, 2022
ronald-cron-arm
requested changes
Feb 2, 2022
ronald-cron-arm
added
needs-work
and removed
needs-review
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
yuhaoth
added
the
needs-review
ronald-cron-arm
requested changes
Feb 8, 2022
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
ronald-cron-arm
approved these changes
Feb 8, 2022
mpg
approved these changes
Feb 9, 2022
mpg
added
approved
ronald-cron-arm
added a commit
to ronald-cron-arm/mbedtls
that referenced
this pull request
Feb 9, 2022
The TLS `client_auth` has been moved from the SSL to the handshake context by Mbed-TLS#5472. Fix the accesses to this field in the SSL context that were introduced by Mbed-TLS#5080 that has been merged a bit before Mbed-TLS#5472. The CI did not re-run on the merge of Mbed-TLS#5472 into developement after the merge of Mbed-TLS#5080 thus did not catch the issue. Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ssl->client_authis used to indicate CertificateRequest received from server. If received, CertificateVerfiy and Certificate MUST be sent by client. The variable is used only in handshake stage.MBEDTLS_SSL_PROTO_TLS1_2ssl->handshakeStatus
READY