Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.28: Add metadata tests for CCM* and TLS1.2-ECJPAKE-to-PMS #6844

Merged
merged 3 commits into from
Jan 27, 2023
Merged

Backport 2.28: Add metadata tests for CCM* and TLS1.2-ECJPAKE-to-PMS #6844

merged 3 commits into from
Jan 27, 2023

Conversation

gilles-peskine-arm
Copy link
Contributor

Very partial backport of #6802: 2.28 doesn't have any of the stuff that was partially missing in development, so these are just minor improvements to scripts.

Gatekeeper checklist

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

@gilles-peskine-arm
NotSupported is specifically about key types
4fa76bd 
Rename NotSupported to KeyTypeNotSupported, because it's only about testing
key management. For algorithms, not-supported is handled by OpFail.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm
Refactoring: new method Algorithm.is_valid_for_operation
7f7630c 
No intended behavior change.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm
Fix documentation
1efe7fd 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, component-crypto Crypto primitives and low-level interfaces needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) labels Dec 24, 2022
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Dec 24, 2022
Merged
3 tasks
mpg
mpg approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me.

@mpg mpg removed the needs-reviewer This PR needs someone to pick it up for review label Jan 24, 2023
@mpg mpg added approved Design and code approved - may be waiting for CI or backports needs-ci Needs to pass CI tests and removed needs-review Every commit must be reviewed by at least two team members, labels Jan 24, 2023
@gilles-peskine-arm gilles-peskine-arm removed the needs-ci Needs to pass CI tests label Jan 26, 2023
@mpg mpg merged commit 27276fc into Mbed-TLS:mbedtls-2.28 Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrzejKurek AndrzejKurek AndrzejKurek approved these changes

@mpg mpg mpg approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-crypto Crypto primitives and low-level interfaces size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gilles-peskine-arm @mpg @AndrzejKurek