Driver-only ecdsa wrapup #7245
Merged
Driver-only ecdsa wrapup #7245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having ECDSA in PSA doesn't help if we're not using PSA from TLS 1.2... Also, move the definition of PSA_HAVE_FULL_ECDSA outside the MBEDTLS_PSA_CRYPTO_CONFIG guards so that it is available in all cases. Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
Turns out TLS 1.3 is using the PK layer for signature generation & verification, and the PK layer is influenced by USE_PSA_CRYPTO. Also update docs/use-psa-crypto.md accordingly. Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
mpg
added
needs-review
3 tasks
Comment on lines
+846
to
+850
| #if defined(PSA_WANT_ALG_ECDSA) && defined(PSA_WANT_KEY_TYPE_ECC_KEY_PAIR) && \ | ||
| defined(PSA_WANT_KEY_TYPE_ECC_PUBLIC_KEY) | ||
| #define PSA_HAVE_FULL_ECDSA 1 | ||
| #endif | ||
|
|
There was a problem hiding this comment.
I'm OK with moving this code forward in the file, but I was wondering: is it possible to have PSA_WANT symbols when MBEDTLS_PSA_CRYPTO_CONFIG is not defined?
I mean, without it we don't include crypto_config.h and also most of the config_psa.h is also skipped (at least the part which automatically sets PSA_WANT symbols).
There was a problem hiding this comment.
We do have PSA_WANT whether MBEDTLS_PSA_CRYPTO_CONFIG is defined or not. The difference that MBEDTLS_PSA_CRYPTO_CONFIG makes is whether PSA_WANT symbols are calculated from MBEDTLS symbols or the other way round.
(I don't know how this applies specifically here.)
AndrzejKurek
approved these changes
Mar 10, 2023
valeriosetti
approved these changes
Mar 10, 2023
mpg
added
approved
|
Open CI is fully green, so no need to wait for Internal to finish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Gatekeeper checklist
check_config.hand ChangeLog