Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: crypto_config_test_driver_extension: handle PUBLIC_KEY the same way as KEY_PAIRs #7798

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Backport: crypto_config_test_driver_extension: handle PUBLIC_KEY the same way as KEY_PAIRs #7798

merged 1 commit into from
Jun 19, 2023

Conversation

valeriosetti
Copy link
Contributor

@valeriosetti valeriosetti commented Jun 19, 2023 •
edited by daverodgman
Loading

This is the backporting of a change to crypto_config_test_driver_extension.h requested in #7641 in this comment

Resolves #7796.

PR checklist

  • changelog not required
  • backport not required as this is the backport
  • tests not required

@valeriosetti
crypto_config_test_driver_extension: treat PUBLIC_KEY the same way as…
e20ec4f 
… KEY_PAIR

Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
@valeriosetti valeriosetti added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests size-s Estimated task size: small (~2d) priority-high High priority - will be reviewed soon labels Jun 19, 2023
@valeriosetti valeriosetti self-assigned this Jun 19, 2023
@valeriosetti
Copy link
Contributor Author

I set the same reviewers as the original PR because they have already a clear idea of what should be done in this PR.

mpg
mpg approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valeriosetti valeriosetti removed the needs-ci Needs to pass CI tests label Jun 19, 2023
gilles-peskine-arm
gilles-peskine-arm approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a semantically faithful backport of the change to crypto_config_test_driver_extension.h in #7641 that affects interfaces that already existed in 2.28, namely, making it auto-enable PUBLIC_KEY symbols.

@gilles-peskine-arm gilles-peskine-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Jun 19, 2023
@gilles-peskine-arm gilles-peskine-arm merged commit cc51e8a into Mbed-TLS:mbedtls-2.28 Jun 19, 2023
@valeriosetti valeriosetti mentioned this pull request Jun 20, 2023
Closed
@valeriosetti valeriosetti deleted the backport-7614 branch December 6, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilles-peskine-arm gilles-peskine-arm gilles-peskine-arm approved these changes

@mpg mpg mpg approved these changes

Assignees

@valeriosetti valeriosetti

Labels
approved Design and code approved - may be waiting for CI or backports priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valeriosetti @mpg @gilles-peskine-arm