Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p256-m: Use the zeroize function from Mbed TLS #8166

Merged
merged 1 commit into from
Sep 12, 2023
Merged

p256-m: Use the zeroize function from Mbed TLS #8166

merged 1 commit into from
Sep 12, 2023

Conversation

gilles-peskine-arm
Copy link
Contributor

Resolve #7883

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

  • changelog not required
  • backport N/A
  • tests not required

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

@gilles-peskine-arm
Use the zeroize function from Mbed TLS
8cae2c2 
Keep using the upstream name, to minimize the differences with the upstream code.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-very-high Highest priority - prioritise this over other review work size-xs Estimated task size: extra small (a few hours at most) labels Sep 6, 2023
tom-cosgrove-arm
tom-cosgrove-arm approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daverodgman daverodgman removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Sep 12, 2023
@daverodgman daverodgman added this pull request to the merge queue Sep 12, 2023
@daverodgman daverodgman added the approved Design and code approved - may be waiting for CI or backports label Sep 12, 2023
Merged via the queue into Mbed-TLS:development with commit 31beb2d Sep 12, 2023
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Sep 13, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

@daverodgman daverodgman daverodgman approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports priority-very-high Highest priority - prioritise this over other review work size-xs Estimated task size: extra small (a few hours at most)
Projects
Roadmap Board for Mbed TLS
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

p256-m: use mbedtls zeroize
3 participants
@gilles-peskine-arm @daverodgman @tom-cosgrove-arm