One minor fix #8171
Merged
One minor fix #8171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix defined but not used warning when MBEDTLS_USE_PSA_CRYPTO, MBEDTLS_PK_HAVE_RFC8410_CURVES and MBEDTLS_PK_HAVE_ECC_KEYS are defined but not MBEDTLS_PEM_WRITE_C. Signed-off-by: Ronald Cron <ronald.cron@arm.com>
ronald-cron-arm
added
component-psa
gilles-peskine-arm
requested changes
Sep 7, 2023
| @@ -67,20 +67,26 @@ | |||
|
|
|||
| #if defined(PSA_WANT_ALG_HKDF) | |||
| #if !defined(MBEDTLS_PSA_ACCEL_ALG_HKDF) | |||
| #define MBEDTLS_HKDF_C | |||
There was a problem hiding this comment.
No: PSA has its own implementation of HKDF, separate from hkdf.c. The existing code here is correct.
There was a problem hiding this comment.
This has come up before and we really should have put a comment there.
There was a problem hiding this comment.
ah I was indeed wondering why it was not caught by the PSA crypto tests.
There was a problem hiding this comment.
I've added some comments instead.
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
ronald-cron-arm
force-pushed
the
misc-minor-fixes
branch
from
8a4893b to
d3d566f
Compare
gilles-peskine-arm
added
approved
3 tasks
ronald-cron-arm
removed
the
needs-backports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix one minor issue I came across while working on the psa-crypto repository.
PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")