Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type of parameter for mbedtls_cipher_info_from_values #8181

Closed
wants to merge 1 commit into from

Conversation

Omcsesz
Copy link

@Omcsesz Omcsesz commented Sep 11, 2023

Description

I thought it would be a good idea to change key_bitlen 's type to size_t because it can not take negative values, so no negative value interval is needed. The other thing is that in this way the code is MISRA compliant, which is important because this library is use in many safety critical applications.

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

  • changelog provided, or not required
  • backport not required
  • tests not required

@Omcsesz Omcsesz force-pushed the development branch 2 times, most recently from d5c9d16 to b26988d Compare September 11, 2023 13:30
Signed-off-by: Omcsesz <omcsesz@gmail.com>
@gabor-mezei-arm
Copy link
Contributor

Thank you for your contribution. Please write an appropriate description for this PR.

@gabor-mezei-arm gabor-mezei-arm added enhancement needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most) component-crypto Crypto primitives and low-level interfaces labels Sep 12, 2023
@Omcsesz
Copy link
Author

Omcsesz commented Sep 13, 2023

Thank you for your contribution. Please write an appropriate description for this PR.

I added the description.

@gilles-peskine-arm gilles-peskine-arm added api-break This issue/PR breaks the API and must wait for a new major version and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Sep 14, 2023
@gilles-peskine-arm
Copy link
Contributor

Thanks, but since this is an API break, it'll have to wait until we start working on the next major version of Mbed TLS, likely early 2024.

@daverodgman daverodgman changed the title Change type of function parameter Change type of parameter to mbedtls_cipher_info_from_values Sep 25, 2023
@daverodgman daverodgman changed the title Change type of parameter to mbedtls_cipher_info_from_values Change type of parameter for mbedtls_cipher_info_from_values Sep 25, 2023
@gilles-peskine-arm
Copy link
Contributor

Thank you for writing this patch! Unfortunately, we could not take it at the time because it was an API break. We are now preparing the next major version of the library, and cipher.h will be removed from the API. Therefore this patch is no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-break This issue/PR breaks the API and must wait for a new major version component-crypto Crypto primitives and low-level interfaces enhancement priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most)
Projects
Status: Mbed TLS 4.0 COULD
Development

Successfully merging this pull request may close these issues.

3 participants