Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.28: Benchmark: add AES_CFB128 and AES_CFB8 #8333

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Backport 2.28: Benchmark: add AES_CFB128 and AES_CFB8 #8333

merged 3 commits into from
Oct 11, 2023

Conversation

yanrayw
Copy link

@yanrayw yanrayw commented Oct 10, 2023 •
edited
Loading

Description

Backport of #8185

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

Yanray Wang added 3 commits October 10, 2023 10:49
benchmark: add AES_CFB128
b382c2b 
Signed-off-by: Yanray Wang <yanray.wang@arm.com>
benchmark: add AES_CFB8
c96db3b 
Signed-off-by: Yanray Wang <yanray.wang@arm.com>
benchmark: improve code readability
c55060d 
Signed-off-by: Yanray Wang <yanray.wang@arm.com>
@yanrayw yanrayw added enhancement needs-review Every commit must be reviewed by at least two team members, priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most) labels Oct 10, 2023
@yanrayw yanrayw self-assigned this Oct 10, 2023
@yanrayw yanrayw mentioned this pull request Oct 10, 2023
Merged
3 tasks
tom-cosgrove-arm
tom-cosgrove-arm approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xkqian
xkqian approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@xkqian xkqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xkqian xkqian added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Oct 11, 2023
@tom-cosgrove-arm tom-cosgrove-arm added this pull request to the merge queue Oct 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 11, 2023
@bensze01
Copy link
Contributor

The all_u16-test_full_cmake_clang unit test failed in the merge queue.

@tom-cosgrove-arm
Copy link
Contributor

The all_u16-test_full_cmake_clang unit test failed in the merge queue.

Thanks. I can't see how that is relevant to this PR, since it only changes the benchmark program :(

@tom-cosgrove-arm tom-cosgrove-arm added this pull request to the merge queue Oct 11, 2023
Merged via the queue into Mbed-TLS:mbedtls-2.28 with commit 44af436 Oct 11, 2023
@gilles-peskine-arm
Copy link
Contributor

The CI failure is in compat.sh on TLS-RSA-PSK-WITH-NULL-SHA384 in DTLS 1.2.

all_u16-test_full_cmake_clang-c-srv-798.log.gz
all_u16-test_full_cmake_clang-c-cli-798.log.gz

It looks like the client (mbedtls) sent an invalid ClientHello. There's no indication of why: we don't have detailed enough logs for compat.sh (which very rarely fails when the rest is ok). It could be a dropped UDP packet on the DTLS connection, but that's unlikely. An obvious explanation is that there's a bug that causes a bad ClientHello with a very low probability. A bug with such low probability is unlikely though. Another possible explanation is port reuse (all of a compat.sh uses the same port) where a duplicated UDP packet from a previous test leaked into the next test.

I'm putting the information I can find here. I don't think it's worth investigating further unless a similar unexplained failure happens with some regularity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

@xkqian xkqian xkqian approved these changes

Assignees

@yanrayw yanrayw

Labels
approved Design and code approved - may be waiting for CI or backports enhancement priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most)
Projects
Non-roadmap pull requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yanrayw @bensze01 @tom-cosgrove-arm @gilles-peskine-arm @xkqian