Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update entropy_poll.c to allow build in z/OS #8726

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Update entropy_poll.c to allow build in z/OS #8726

merged 3 commits into from
Jan 23, 2024

Conversation

v1gnesh
Copy link
Contributor

@v1gnesh v1gnesh commented Jan 22, 2024 •
edited
Loading

Description

Adding the necessary flag to allow this to build in z/OS (an IBM mainframe operating system).

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

@v1gnesh
Update entropy_poll.c
3c129dd 
Signed-off-by: v1gnesh <v1gnesh@users.noreply.github.com>
@v1gnesh
Create 8726.txt changelog entry
d0b55ed 
Signed-off-by: v1gnesh <v1gnesh@users.noreply.github.com>
gilles-peskine-arm
gilles-peskine-arm previously approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about __MVS__ vs __TOS_MVS__, but ok.

@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, component-platform Portability layer and build scripts needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most) labels Jan 22, 2024
yanesca
yanesca approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanesca yanesca added needs-ci Needs to pass CI tests and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Jan 22, 2024
yanesca
yanesca requested changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI has failed.

ChangeLog.d/8726.txt Outdated Show resolved Hide resolved
@yanesca yanesca added needs-work and removed needs-ci Needs to pass CI tests labels Jan 23, 2024
@v1gnesh @yanesca
Update ChangeLog.d/8726.txt
468c02c 
Co-authored-by: Janos Follath <janos.follath@arm.com>
Signed-off-by: v1gnesh <v1gnesh@users.noreply.github.com>
@yanesca yanesca added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests and removed needs-work labels Jan 23, 2024
gilles-peskine-arm
gilles-peskine-arm approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yanesca
yanesca approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanesca yanesca added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests labels Jan 23, 2024
@yanesca yanesca added this pull request to the merge queue Jan 23, 2024
Merged via the queue into Mbed-TLS:development with commit aa3fa98 Jan 23, 2024
3 checks passed
@v1gnesh v1gnesh deleted the patch-1 branch January 24, 2024 02:30
@davidhorstmann-arm davidhorstmann-arm mentioned this pull request Aug 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorTodorovskiIBM IgorTodorovskiIBM IgorTodorovskiIBM left review comments

@yanesca yanesca yanesca approved these changes

@gilles-peskine-arm gilles-peskine-arm gilles-peskine-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-platform Portability layer and build scripts priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most)
Projects
Barriers
Archived in project
Non-roadmap pull requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v1gnesh @yanesca @gilles-peskine-arm @IgorTodorovskiIBM