Fix uint32_t printed as unsigned int #9225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is ok in practice since we don't support 16-bit platforms, but it makes `arm-none-eabi-gcc-10 -mthumb -Wformat` complain. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
added
enhancement
needs-review
|
Is there a problem with the CI? DCO status is normally reported quickly |
gilles-peskine-arm
force-pushed
the
tls13-debug-print-uint32-fix
branch
from
5f09f86 to
6f60fbe
Compare
|
DCO occasionally gets lost on the way. I've force-pushed a new identical commit to kick it again. |
|
Not helping and #9189 DCO also hasn't reported back. The DCO job is down. |
paul-elliott-arm
approved these changes
Jun 5, 2024
4 tasks
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
force-pushed
the
tls13-debug-print-uint32-fix
branch
from
6f60fbe to
69770aa
Compare
|
I force-pushed a new head with only a commit date change to re-run the CI (DCO service outage, and unrelated intermittent failure on the internal CI that's now fixed). |
gilles-peskine-arm
added
approved
Merged
via the queue into
Mbed-TLS:development
with commit Jun 10, 2024
c9ab367
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ok in practice since we don't support 16-bit platforms, but it makes
arm-none-eabi-gcc-10 -mthumb -Wformatcomplain.Fixes
build_arm_none_eabi_gcc_no_64bit_multiplicationon my machine (arm-none-eabi-gcc 10.3). The CI doesn't complain because we're using an older compiler version.PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")