Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

psasim: small fixes to all.sh and test bash scripts #9427

Merged
merged 1 commit into from
Aug 7, 2024
Merged

psasim: small fixes to all.sh and test bash scripts #9427

merged 1 commit into from
Aug 7, 2024

Conversation

valeriosetti
Copy link
Contributor

@valeriosetti valeriosetti commented Jul 26, 2024 •
edited
Loading

Description

This PR introduces some small fixes to all.sh and psasim 's bash scripts.

These changes were originally part of #9371, but since that PR is becoming too long, we decided to split minor parts here.

This PR conflict with #8226, but since that's more urgent, this one will be set as depending on the former.

PR checklist

  • changelog not required
  • development PR not required
  • framework PR not required
  • 3.6 PR required
  • 2.28 PR required
  • tests not required

@valeriosetti valeriosetti added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests size-xs Estimated task size: extra small (a few hours at most) labels Jul 26, 2024
@valeriosetti valeriosetti self-assigned this Jul 26, 2024
@valeriosetti valeriosetti mentioned this pull request Jul 26, 2024
Open
5 tasks
tom-cosgrove-arm
tom-cosgrove-arm previously approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, subject to CI

@valeriosetti valeriosetti removed the needs-ci Needs to pass CI tests label Jul 29, 2024
@tom-cosgrove-arm
Copy link
Contributor

CI is green, pinging @minosgalanakis for reivew

@valeriosetti valeriosetti added the needs-preceding-pr Requires another PR to be merged first label Jul 29, 2024
@valeriosetti valeriosetti removed the needs-preceding-pr Requires another PR to be merged first label Aug 5, 2024
@valeriosetti
Copy link
Contributor Author

valeriosetti commented Aug 5, 2024 •
edited
Loading

Since #8226 was merged, I rebased this PR on top of development so if the CI is OK the PR is ready again for reviews

minosgalanakis
minosgalanakis previously approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@minosgalanakis minosgalanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tom-cosgrove-arm
tom-cosgrove-arm previously approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm tom-cosgrove-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Aug 6, 2024
@valeriosetti
psasim: small fixes to all.sh and test bash scripts
2016d66 
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
tom-cosgrove-arm
tom-cosgrove-arm approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@tom-cosgrove-arm tom-cosgrove-arm added needs-review Every commit must be reviewed by at least two team members, and removed approved Design and code approved - may be waiting for CI or backports labels Aug 6, 2024
minosgalanakis
minosgalanakis approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@minosgalanakis minosgalanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Internal CI failures are check-out timeout and not related to the changes.

@tom-cosgrove-arm tom-cosgrove-arm added this pull request to the merge queue Aug 7, 2024
@tom-cosgrove-arm tom-cosgrove-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Aug 7, 2024
Merged via the queue into Mbed-TLS:development with commit 195e164 Aug 7, 2024
5 of 6 checks passed
@valeriosetti valeriosetti deleted the psasim-small-fixes branch December 6, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

@minosgalanakis minosgalanakis minosgalanakis approved these changes

Assignees

@valeriosetti valeriosetti

Labels
approved Design and code approved - may be waiting for CI or backports size-xs Estimated task size: extra small (a few hours at most)
Projects
Roadmap Board for Mbed TLS
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valeriosetti @tom-cosgrove-arm @minosgalanakis