Correct Adform adapter bid response adId value (prebid#947)

MbidIO · Mar 6, 2017 · 269b1bd · 269b1bd
1 parent 8589c1c
commit 269b1bd
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/adapters/adform.js b/src/adapters/adform.js
@@ -2,6 +2,7 @@ var utils = require('../utils.js');
 var adloader = require('../adloader.js');
 var bidmanager = require('../bidmanager.js');
 var bidfactory = require('../bidfactory.js');
+var STATUSCODES = require('../constants.json').STATUS;
 
 function AdformAdapter() {
 
@@ -70,7 +71,7 @@ function AdformAdapter() {
         if (adItem && adItem.response === 'banner' &&
             verifySize(adItem, bid.sizes)) {
 
-          bidObject = bidfactory.createBid(1);
+          bidObject = bidfactory.createBid(STATUSCODES.GOOD, bid);
           bidObject.bidderCode = bidder;
           bidObject.cpm = adItem.win_bid;
           bidObject.cur = adItem.win_cur;
@@ -80,7 +81,7 @@ function AdformAdapter() {
           bidObject.dealId = adItem.deal_id;
           bidmanager.addBidResponse(bid.placementCode, bidObject);
         } else {
-          bidObject = bidfactory.createBid(2);
+          bidObject = bidfactory.createBid(STATUSCODES.NO_BID, bid);
           bidObject.bidderCode = bidder;
           bidmanager.addBidResponse(bid.placementCode, bidObject);
         }

diff --git a/test/spec/adapters/adform_spec.js b/test/spec/adapters/adform_spec.js
@@ -81,6 +81,13 @@ describe('Adform adapter', () => {
       assert.equal(_bidObject.bidderCode, 'adform');
     });
 
+    it('should correctly set bid response adId', () => {
+      const addResponse = bidManager.addBidResponse;
+      assert.equal('abc', addResponse.getCall(0).args[1].adId);
+      assert.equal('123', addResponse.getCall(1).args[1].adId);
+      assert.equal('a1b', addResponse.getCall(2).args[1].adId);
+    });
+
     beforeEach(() => {
       sandbox.stub(bidManager, 'addBidResponse');
       $$PREBID_GLOBAL$$._adf_callback([
@@ -112,6 +119,7 @@ describe('Adform adapter', () => {
     _adapter.callBids({
       bids: [
         {
+          bidId: 'abc',
           placementCode: 'code-1',
           sizes: [ [ 100, 100], [ 90, 90 ] ],
           params: {
@@ -122,6 +130,7 @@ describe('Adform adapter', () => {
           tid: 45
         },
         {
+          bidId: '123',
           placementCode: 'code-2',
           sizes: [ [ 100, 100] ],
           params: {
@@ -131,6 +140,7 @@ describe('Adform adapter', () => {
           }
         },
         {
+          bidId: 'a1b',
           placementCode: 'code-3',
           sizes: [ [ 50, 40], [ 40, 50 ] ],
           params: {