Rubicon adapter: add a floor variable (prebid#964)

* Add a floor variable * Added floor parameter test
MbidIO · Mar 6, 2017 · 7cf02e7 · 7cf02e7
1 parent 63f6747
commit 7cf02e7
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/src/adapters/rubicon.js b/src/adapters/rubicon.js
@@ -177,6 +177,7 @@ function RubiconAdapter() {
       siteId,
       zoneId,
       position,
+      floor,
       keywords,
       visitor,
       inventory,
@@ -185,6 +186,7 @@ function RubiconAdapter() {
     } = bid.params;
 
     // defaults
+    floor = (floor = parseFloat(floor)) > 0.01 ? floor : 0.01;
     position = position || 'btf';
 
     // use rubicon sizes if provided, otherwise adUnit.sizes
@@ -204,7 +206,7 @@ function RubiconAdapter() {
       'size_id', parsedSizes[0],
       'alt_size_ids', parsedSizes.slice(1).join(',') || undefined,
       'p_pos', position,
-      'rp_floor', '0.01',
+      'rp_floor', floor,
       'tk_flint', getIntegration(),
       'p_screen_res', _getScreenResolution(),
       'kw', keywords,

diff --git a/test/spec/adapters/rubicon_spec.js b/test/spec/adapters/rubicon_spec.js
@@ -262,7 +262,7 @@ describe('the rubicon adapter', () => {
           expect(query['alt_size_ids']).to.equal('57,59');
 
         });
-
+       
         it('should not send a request and register an error bid if no valid sizes', () => {
 
           var sizesBidderRequest = clone(bidderRequest);
@@ -277,6 +277,19 @@ describe('the rubicon adapter', () => {
           expect(bids[0].getStatusCode()).to.equal(CONSTANTS.STATUS.NO_BID);
 
         });
+
+        it('should allow a floor override', () => {
+
+          var floorBidderRequest = clone(bidderRequest);
+          floorBidderRequest.bids[0].params.floor = 2;
+
+          rubiconAdapter.callBids(floorBidderRequest);
+
+          let query = parseQuery(xhr.requests[0].url.split('?')[1]);
+
+          expect(query['rp_floor']).to.equal('2');
+
+        });
 
       });
 
@@ -658,4 +671,4 @@ describe('the rubicon adapter', () => {
 
 function clone(obj) {
   return JSON.parse(JSON.stringify(obj));
-}
+}