Related links #1054

JaviviJR · 2024-08-22T16:48:50Z

Added new dynamic field in profile section witch let us to add related links.

templates/user/settings/profile.html.twig

BentiGorlich · 2024-09-03T07:39:29Z

Can you implement it the mastodon way where you have a name-link combination? So that each add link field has an associated name field.

JaviviJR · 2024-09-03T10:52:17Z

Can you implement it the mastodon way where you have a name-link combination? So that each add link field has an associated name field.

Do you want that user can add just links or whatever data user wants like Mastodon?

BentiGorlich · 2024-09-04T08:44:25Z

Limit it to links would be fine for me, but I don't think that it makes sense 🤔

BentiGorlich · 2024-09-04T08:46:42Z

assets/controllers/form-related-links_controller.js

+
+    #addButtonDeleteLink(item) {
+        const removeFormButton = document.createElement('button');
+        removeFormButton.innerText = '⌫';


I think overwriting innerHtml with the font awesome trashcan icon (https://fontawesome.com/icons/trash?f=classic&s=solid) would be better. Then you could also make it a button:

<div class="btn btn__secondary"> <i class="fa-solid fa-trash"></i> </div>

BentiGorlich · 2024-09-04T08:50:11Z

src/Entity/User.php

@@ -894,4 +897,14 @@ public function canUpdateUser(User $actor): bool
            return $this->apDomain === $actor->apDomain;
        }
    }
+
+    public function getRelatedLinks(): array


Could you add phpDoc so we know which kind of array is returned? I really liked if the returned value would be of RelatedLink[] so an array of objects, so we can add some validation logic so we can mark links as "checked" or something so we know that the rel=me is actually correct

Discussed Discussed on element chat.
I don't know a elegant way to denormalize the json field from table and return it on get method. This'll required some dependencies inside entity that I think is not a good practice.
Instead, I created a RelatedLinkDTO class and this will be returned in UserDTO.

melroy89 · 2024-09-07T13:54:35Z

Can you implement it the mastodon way where you have a name-link combination? So that each add link field has an associated name field.

Agreed that would be helpful, so it's basically a key/value list.

BentiGorlich · 2024-09-12T16:57:14Z

src/Form/UserRelatedDataType.php

+    {
+        $builder
+            ->add('label', TextType::class)
+            ->add('link', UrlType::class)


The url type force this value to be a url. Even if I insert something normal, it still comes out as a url. In general I think this variable/field should be called value instead

modified link by value

BentiGorlich

I'd love if the add button would something like this (but that is not a requirement):

I noticed that the links are not yet displayed on the profile page. Are you planning on adding that in this PR?
(The activity pub representation of the fields is also missing, but I expected to do that myself anyways :) but if you'd like to try that as well, feel free to do so)

BentiGorlich · 2024-09-12T16:58:41Z

src/DTO/RelatedLinkDTO.php

+class RelatedLinkDTO
+{
+    private string $label;
+    private string $link;


Same here

Suggested change

private string $link;

private string $value;

BentiGorlich · 2024-09-12T16:58:52Z

src/DTO/RelatedLinkDTO.php

+{
+    private string $label;
+    private string $link;
+    private bool $verified = false;


Suggested change

private bool $verified = false;

private bool $verifiedLink = false;

BentiGorlich · 2024-09-12T17:01:06Z

src/Entity/User.php

+        return $this->relatedLinks;
+    }
+
+    public function setRelatedLinks(array $relatedLinks): void


This one is actually not used. Maybe make the variable private and use this one?

BentiGorlich · 2024-09-12T17:01:22Z

src/Factory/UserFactory.php

+//        $temp = $this->denormalizer->denormalize($user->getRelatedLinks(), sprintf('%s[]', RelatedLinkDTO::class));
+


need to be removed

BentiGorlich · 2024-09-12T17:03:52Z

assets/controllers/form-related-links_controller.js

+        this.indexValue++;
+    }
+
+    #addButtonDeleteLink(item) {


What is this hashtag for?

Define a method private

https://railsdesigner.com/proper-stimulus-controllers/

Could be added on a utility file.

Today I learned... https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/Private_properties

BentiGorlich · 2024-09-12T17:04:28Z

assets/styles/layout/_forms.scss

+.related-link-row button {
+    padding: 0;
+    background: none;
+    font-size: 1.5rem;
+    border: 0;
+    color: var(--kbin-input-text-color);
+
+}


please remove that and add the class btn__secondary to the trash icon buttons. Then they will look like other buttons in our UI

BentiGorlich · 2024-09-12T17:09:44Z

translations/messages.en.yaml

@@ -890,3 +890,4 @@ admin_users_suspended: Suspended
 admin_users_banned: Banned
 user_verify: Activate account
 max_image_size: Maximum file size
+related_links: Related links


Please keep newlines at the end of files

BentiGorlich · 2024-09-12T17:13:27Z

Oh and please change the target of the PR to dev/new_features

Added new dynamic field in profile section witch let us to add related links.

JaviviJR · 2024-09-16T19:29:12Z

I'd love if the add button would something like this (but that is not a requirement):

I noticed that the links are not yet displayed on the profile page. Are you planning on adding that in this PR? (The activity pub representation of the fields is also missing, but I expected to do that myself anyways :) but if you'd like to try that as well, feel free to do so)

Check it out with the new changes.
I tried to keep it centered in vertical line which separate the two fields, but I couldn't.

Also I modified userBox component to show related links in profile.

BentiGorlich · 2024-09-16T20:03:31Z

First of all thanks for your time and effort ❤️
I will have a look at it in the next days.

From your comment and screenshots I (already) have a few remarks (sorry 🙈):

I tried to keep it centered in vertical line which separate the two fields, but I couldn't.

I think I did it by making a div with a margin left the same size as the buttons and then just put text-align: center in there.

I modified userBox component to show related links in profile.

What happens when the value is not a link?

melroy89 · 2024-09-16T20:07:43Z

There is a conflict with translations/messages.es.yaml. Ideally only change the English language file. And translate the rest in Weblate.

Javivi added 6 commits August 21, 2024 21:59

related links

31c2f5d

related links

7debca3

related links

5e61bb1

php fixer

09a1a0d

Merge branch 'main' into related-links

eb2daa7

cleaning

8a3275b

melroy89 reviewed Aug 22, 2024

View reviewed changes

templates/user/settings/profile.html.twig Show resolved Hide resolved

BentiGorlich linked an issue Aug 27, 2024 that may be closed by this pull request

Set rel="me" links on profile #839

Open

BentiGorlich assigned JaviviJR Aug 27, 2024

BentiGorlich added enhancement New feature or request frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end labels Aug 27, 2024

Javivi and others added 4 commits September 2, 2024 15:09

Required changes.

6c2ca55

docs(contributor): contrib-readme-action has updated readme

8174113

Merge remote-tracking branch 'origin/main' into related-links

b750fa1

Merge branch 'main' into related-links

3055403

BentiGorlich added this to the v1.8.0 milestone Sep 4, 2024

BentiGorlich reviewed Sep 4, 2024

View reviewed changes

BentiGorlich reviewed Sep 12, 2024

View reviewed changes

BentiGorlich requested changes Sep 12, 2024

View reviewed changes

JaviviJR force-pushed the related-links branch 2 times, most recently from edc97fa to 481b0f7 Compare September 16, 2024 16:58

JaviviJR changed the base branch from main to dev/new_features September 16, 2024 16:58

JaviviJR force-pushed the related-links branch 2 times, most recently from ffbdc54 to 98ed7e1 Compare September 16, 2024 17:38

Related links

3f043fd

Added new dynamic field in profile section witch let us to add related links.

JaviviJR force-pushed the related-links branch from 98ed7e1 to 3f043fd Compare September 16, 2024 17:41

Changes requested

68d6d11

JaviviJR force-pushed the related-links branch from cb071ab to 68d6d11 Compare September 16, 2024 19:38

JaviviJR added 2 commits September 16, 2024 22:48

Changes requested

a5b7f85

Changes requested

1d0f707

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Related links #1054

Related links #1054

JaviviJR commented Aug 22, 2024 •

edited

Loading

BentiGorlich commented Sep 3, 2024

JaviviJR commented Sep 3, 2024

BentiGorlich commented Sep 4, 2024

BentiGorlich Sep 4, 2024

JaviviJR Sep 16, 2024

BentiGorlich Sep 4, 2024

JaviviJR Sep 16, 2024

melroy89 commented Sep 7, 2024

BentiGorlich Sep 12, 2024

JaviviJR Sep 16, 2024

BentiGorlich left a comment

BentiGorlich Sep 12, 2024

JaviviJR Sep 16, 2024

BentiGorlich Sep 12, 2024

JaviviJR Sep 16, 2024

BentiGorlich Sep 12, 2024

JaviviJR Sep 16, 2024

BentiGorlich Sep 12, 2024

JaviviJR Sep 16, 2024

BentiGorlich Sep 12, 2024

JaviviJR Sep 16, 2024 •

edited

Loading

melroy89 Sep 16, 2024

BentiGorlich Sep 12, 2024

JaviviJR Sep 16, 2024

BentiGorlich Sep 12, 2024

BentiGorlich commented Sep 12, 2024

JaviviJR commented Sep 16, 2024 •

edited

Loading

BentiGorlich commented Sep 16, 2024

melroy89 commented Sep 16, 2024

	private bool $verified = false;
	private bool $verifiedLink = false;

		// $temp = $this->denormalizer->denormalize($user->getRelatedLinks(), sprintf('%s[]', RelatedLinkDTO::class));

Related links #1054

Are you sure you want to change the base?

Related links #1054

Conversation

JaviviJR commented Aug 22, 2024 • edited Loading

BentiGorlich commented Sep 3, 2024

JaviviJR commented Sep 3, 2024

BentiGorlich commented Sep 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

melroy89 commented Sep 7, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BentiGorlich left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JaviviJR Sep 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BentiGorlich commented Sep 12, 2024

JaviviJR commented Sep 16, 2024 • edited Loading

BentiGorlich commented Sep 16, 2024

melroy89 commented Sep 16, 2024

JaviviJR commented Aug 22, 2024 •

edited

Loading

JaviviJR Sep 16, 2024 •

edited

Loading

JaviviJR commented Sep 16, 2024 •

edited

Loading