Ran compose recipes + Move to NPM + port 8008 (Part 6)

[melroy89]

• Clean-up clover.xml file (should have never been checked in the first place)
• Move from Yarn to NPM (See Webpack Encore PR: Recommend NPM instead of Yarn symfony/recipes#1229)
  • Indirectly also updates all NodeJS packages to the latest version
• I dare to run the recipe symfony/webpack-encore-bundle as well as doctrine/doctrine-bundle this time, but:
  • I confirmed a regression in Doctrine with the report_fields_where_declared setting. Which is used to switch to a "new mapping driver mode as of Doctrine ORM 2.16", that breaks class inheritance with the separate sequence generator table we use for the child classes of the Vote class. Anyhow, this option needs to be set to false (do not opt-in). See also: All sequences merged into one since the merge of #10455 doctrine/orm#10953
• Update Docker locally mapped port from 80 to port 8008 (BOOB 🔒 )

[e-five256]

I'm having issues building docker for this with

 => ERROR [messenger_ap builder-nodejs 9/9] RUN npm run build                                                                                                                                                                            0.8s
------
 > [messenger_ap builder-nodejs 9/9] RUN npm run build:
0.743 
0.743 > build
0.743 > encore production --progress
0.743 
0.747 sh: encore: not found
------
failed to solve: process "/bin/sh -c npm run build" did not complete successfully: exit code: 127

[melroy89]

I'm having issues building docker for this with

 => ERROR [messenger_ap builder-nodejs 9/9] RUN npm run build                                                                                                                                                                            0.8s
------
 > [messenger_ap builder-nodejs 9/9] RUN npm run build:
0.743 
0.743 > build
0.743 > encore production --progress
0.743 
0.747 sh: encore: not found
------
failed to solve: process "/bin/sh -c npm run build" did not complete successfully: exit code: 127

Sorry about that, I tested Docker earlier, but I added NODE_ENV=production later I think. Anyhow, I include --include=dev now. I did the same on other places just to be sure. And also execute a npm run build with production env var on post-upgrade script.

@e-five256 try again 👍🏽

[e-five256]

this builds for my local dev env, and I didn't notice any issues, but I'm not as knowledgeable compared to my peers so not sure if you want a second opinion just to be cautious, since it seems like a pretty big change. I also think it's a good idea to communicate maybe in matrix general once merged as a heads up that the www container port on the host changed if people need to repoint things to it

[ghost]

It looks like we don't need to use node:lts-alpine image to support whatever was broken with yarn, the latest release of node:alpine works fine now. I doubled checked that and all these changes on a docker dev instance with db test fixtures, everything still seems to work fine.

Edit: added commit with this change.

[melroy89]

Thanks for the improvement @nobodyatroot