Full recode #70
Merged
Full recode #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* GitHub Actions * Issue templates * CONTRIBUTING.md * CODE_OF_CONDUCT.md
Add TypeScript as a dependency and move files to their new folders
Old Code.
tables are created before some functions are created. Causing errors when referencing them as default values inside tables
|
Done with testing locally. Currently preparing for production testing. Gotta improve cookies and documentation. Then this PR can be merged |
SpraxDev
force-pushed
the
typescript-recode
branch
from
1ace346 to
f904a20
Compare
+ Using one secret for everything by providing a function that returns the first x bytes as a buffer (instead of base64 string) + Fixed demo-page not working with expired/invalid cookie Should have done so earlier... Moving code inside classes and functions instead of top-level scope, allows for imports without the risk of any race conditions. `mail.ts` importing `dynamicPageGenerator.ts` caused the `global` variable to be instantiated and trying to use `cfg` from `index.ts` before `cfg` could have had the chance to be populated correctly... Thus this unreadable, large commit :/
SpraxDev
force-pushed
the
typescript-recode
branch
from
30ed94f to
8fddf1c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #54