Remove useless pointer

The boolean does not need to be a pointer (default value, false, is fine).
McKael · Apr 3, 2018 · cd4b3eb · cd4b3eb
1 parent 247e877
commit cd4b3eb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/gh/checkrelease.go b/gh/checkrelease.go
@@ -131,7 +131,7 @@ func (c *Config) getOldState(repo string) RepoState {
 	return RepoState{Repo: repo}
 }
 
-func (c *Config) checkRepoReleases(ctx context.Context, wID int, prereleases *bool, prevState RepoState) (*Release, error) {
+func (c *Config) checkRepoReleases(ctx context.Context, wID int, prereleases bool, prevState RepoState) (*Release, error) {
 	client := c.client
 
 	pp := strings.Split(prevState.Repo, "/")
@@ -192,7 +192,7 @@ func (c *Config) checkRepoReleases(ctx context.Context, wID int, prereleases *bo
 
 		if r.Prerelease != nil && *r.Prerelease {
 			// This is a pre-release
-			if prereleases == nil || !*prereleases {
+			if !prereleases {
 				continue
 			}
 		}

diff --git a/gh/config.go b/gh/config.go
@@ -59,9 +59,10 @@ type Config struct {
 	client *github.Client
 }
 
+// RepoConfig contains the user configuration for a single repository
 type RepoConfig struct {
 	Repo        string `json:"repo"`        // owner/repo_name
-	Prereleases *bool  `json:"prereleases"` // include prereleases
+	Prereleases bool   `json:"prereleases"` // include prereleases
 }
 
 // States is a struct that contains the states of all checked releases